-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51287/#review146358
-----------------------------------------------------------
Hi Miklos,
Thanks for the patch Miklos!
I am not absoultely sure about the "business" requirements, but if we accept
that then there only a few nits in the code.
Could this change mean, than the following lines could be separated in the
beeline command line output?
Like this:
0: jdbc:hive2://localhost:10000> show create table escape_comments_tbl1;
+----------------------------------------------------+
show create table escape_comments_tbl1;
| createtab_stmt |
Have not tried it, just curious :)
Thanks,
Peter
beeline/src/java/org/apache/hive/beeline/BeeLine.java (line 992)
<https://reviews.apache.org/r/51287/#comment212753>
nit space between ){
beeline/src/java/org/apache/hive/beeline/BeeLine.java (line 993)
<https://reviews.apache.org/r/51287/#comment212751>
nit: spaces after ','
- Peter Vary
On Aug. 22, 2016, 3:15 p.m., Miklos Csanady wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/51287/
> -----------------------------------------------------------
>
> (Updated Aug. 22, 2016, 3:15 p.m.)
>
>
> Review request for hive, Peter Vary, Sergio Pena, and Vihang Karajgaonkar.
>
>
> Bugs: HIVE-14525
> https://issues.apache.org/jira/browse/HIVE-14525
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-14525: beeline still writing log data to stdout as of version 2.1.0
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/BeeLine.java e0fa032
>
> Diff: https://reviews.apache.org/r/51287/diff/
>
>
> Testing
> -------
>
> Beeline with redirected input and output with script file and without one.
>
>
> Thanks,
>
> Miklos Csanady
>
>
