> On Aug. 31, 2016, 1:48 a.m., Chaoyu Tang wrote: > > hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonUtils.java, > > line 488 > > <https://reviews.apache.org/r/51435/diff/3/?file=1488428#file1488428line488> > > > > I missed this in last review. > > Utilities class is form package ql and packaged in hive-exec.jar, I am > > not sure currently if this jar is mandatory to WebHCat server or not in > > runtime. If not, will that mean we need an additional runtime jar > > (hive-exec.jar)? > > Is it better to refactor the maskIfPassword from ql to common package? > > Peter Vary wrote: > I did not have to add any new dependency to the pom.xml - the Utilities > was just there :) > > So I checked it now, and it is coming from hive-hcatalog-core, which is > directly depending on it. > - If nothing else, you are right, that we should change the pom.xml of > svr, to reflect the direct dependency now. > - Or we could refactor it from the ql package as you suggested. > > What is your suggestion? Which direction should we move? > > Thanks, > Peter > > Chaoyu Tang wrote: > For me I might move it to common package.
Refactored, thanks for the suggestion - Peter ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/51435/#review147400 ----------------------------------------------------------- On Aug. 30, 2016, 6:34 a.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/51435/ > ----------------------------------------------------------- > > (Updated Aug. 30, 2016, 6:34 a.m.) > > > Review request for hive, Chaoyu Tang, Gabor Szadovszky, Sergio Pena, and > Barna Zsombor Klara. > > > Bugs: HIVE-14426 > https://issues.apache.org/jira/browse/HIVE-14426 > > > Repository: hive-git > > > Description > ------- > > Used HiveConf.stripHiddenConfigurations to remove sensitive information from > configuration dump. Had to refactor, so it could be applied to simple > Configuration objects too, like AppConfig. > > Used Utilities.maskIfPassword to remove sensitive information from property > dump > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 14a538b > common/src/java/org/apache/hadoop/hive/conf/HiveConfUtil.java 073a978 > > hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/AppConfig.java > dd1208b > > hcatalog/webhcat/svr/src/main/java/org/apache/hive/hcatalog/templeton/tool/TempletonUtils.java > 201e647 > > Diff: https://reviews.apache.org/r/51435/diff/ > > > Testing > ------- > > Manually - checked both > > > Thanks, > > Peter Vary > >
