-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/51334/
-----------------------------------------------------------
(Updated Sept. 6, 2016, 1:10 p.m.)
Review request for hive, Naveen Gangam, Peter Vary, Sergio Pena, and Szehon Ho.
Changes
-------
- Fixed the findings from the review.
- Removed the super csv from the beeline.cmd and beeline.sh files since it is
not needed any more.
- Fixed the output format for cases when the result contains empty or null
values. Also added some test cases with empty and null values.
Bugs: HIVE-14404
https://issues.apache.org/jira/browse/HIVE-14404
Repository: hive-git
Description
-------
Changed the class which is used to generate the output for the formats 'csv2',
'tsv2' and 'dsv' not to use SuperCSV any more and support multiple characters
as delimiter.
The class implements the same escaping logic as it had with SuperCSV if the
quoting is not disabled.
Extended the TestBeeLineWithArgs tests with new test steps which are using
multiple characters as delimiter.
This review is a follow-up for the review 50896.
Diffs (updated)
-----
beeline/pom.xml d03f770
beeline/src/java/org/apache/hive/beeline/BeeLine.java 8e65e39
beeline/src/java/org/apache/hive/beeline/BeeLineOpts.java 59fbca3
beeline/src/java/org/apache/hive/beeline/SeparatedValuesOutputFormat.java
66d9fd0
bin/beeline.cmd 971e20b
bin/ext/beeline.sh 8052c45
itests/hive-unit/src/test/java/org/apache/hive/beeline/TestBeeLineWithArgs.java
1ca7623
Diff: https://reviews.apache.org/r/51334/diff/
Testing
-------
- Tested manually in BeeLine.
- Extended the TestBeeLineWithArgs tests with new test steps which are using
multiple characters as delimiter.
Thanks,
Marta Kuczora
