> On Sept. 22, 2016, 11:53 p.m., Sergey Shelukhin wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java, line 154 > > <https://reviews.apache.org/r/52171/diff/1/?file=1508429#file1508429line154> > > > > is isNative just coming from the resistry? I wonder why these two > > methods exist - you can either choose a type, or not choose a type, for the > > same registry?
Previously you could not choose a type - the various register methods would automatically set the type to BUILTIN (system registry) or TEMPRORARY (session registry). That was the problem - when registerToSessionRegistry() adds the persistent UDF it has the wrong type. Trying to keep the old method signatures (which would depend on the default builtin/temporary behavior. Note that the methods to specify the type are set to private, and only used for persistent UDFs. - Jason ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52171/#review150102 ----------------------------------------------------------- On Sept. 22, 2016, 7:21 p.m., Jason Dere wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52171/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2016, 7:21 p.m.) > > > Review request for hive and Sergey Shelukhin. > > > Bugs: HIVE-14819 > https://issues.apache.org/jira/browse/HIVE-14819 > > > Repository: hive-git > > > Description > ------- > > Patch to allow the registry to set PERSISTENT type when registering permanent > functions to the session registry. Previously all functions added to session > registry had the TEMPORARY tag > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionInfo.java 30ba996 > ql/src/java/org/apache/hadoop/hive/ql/exec/Registry.java 05926b5 > ql/src/java/org/apache/hadoop/hive/ql/exec/WindowFunctionInfo.java a16d9e5 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java > 911b86b > ql/src/test/org/apache/hadoop/hive/ql/exec/TestFunctionRegistry.java > d2d5a1b > > Diff: https://reviews.apache.org/r/52171/diff/ > > > Testing > ------- > > Added tests to TestFunctionRegistry > > > Thanks, > > Jason Dere > >
