----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/52127/#review150863 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java (line 278) <https://reviews.apache.org/r/52127/#comment218951> This function belongs in ASTConverter with private visibility. ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 3026) <https://reviews.apache.org/r/52127/#comment218941> isUDTF boolean is redundant. Can be replaced with genericUDTF != null. ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 3037) <https://reviews.apache.org/r/52127/#comment218942> LOG.debug ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 3041) <https://reviews.apache.org/r/52127/#comment218939> isUDTF is always true here. Can get rid of it. ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 3074) <https://reviews.apache.org/r/52127/#comment218943> throw Exception ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 3077) <https://reviews.apache.org/r/52127/#comment218940> no need for isDebugEnabled(), instead use {} within debug() ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 3256) <https://reviews.apache.org/r/52127/#comment218948> Does this mean we won't support lateral view explode? That's one of the most used udtfs. ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java (line 3334) <https://reviews.apache.org/r/52127/#comment218950> whitespace. - Ashutosh Chauhan On Sept. 21, 2016, 6:01 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/52127/ > ----------------------------------------------------------- > > (Updated Sept. 21, 2016, 6:01 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-14806 > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableFunctionScan.java > PRE-CREATION > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTConverter.java > 9f5e733 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/SqlFunctionConverter.java > 911b86b > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java e2ddb14 > > Diff: https://reviews.apache.org/r/52127/diff/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
