[ 
https://issues.apache.org/jira/browse/HIVE-2578?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13149865#comment-13149865
 ] 

jirapos...@reviews.apache.org commented on HIVE-2578:
-----------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2825/
-----------------------------------------------------------

Review request for Ning Zhang.


Summary
-------

Basically there is an additional place in Hive where a child JVM can be 
started, that I wasn't aware of. I added to that place (MapRedLocalTask) update 
of debug environment variables as it is being already done in MapRedTask.

By the way I added new debug option: swapSuspend, since I was very often using 
hive --debug:mainSuspend=n,childSuspend=y whereas now --debug:swapSuspend will 
be sufficient. 


This addresses bug HIVE-2578.
    https://issues.apache.org/jira/browse/HIVE-2578


Diffs
-----

  trunk/bin/ext/debug.sh 1201858 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapRedTask.java 1201858 
  trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/MapredLocalTask.java 1201858 

Diff: https://reviews.apache.org/r/2825/diff


Testing
-------

Tested on sample queries that it works (e.g. select s1.key, count(*) from src 
s1 join src s2 on s1.key = s2.key  group by s1.key, s2.value; )


Thanks,

Robert


                
> Debug mode in some situations doesn't work properly when child JVM  is 
> started from MapRedLocalTask
> ---------------------------------------------------------------------------------------------------
>
>                 Key: HIVE-2578
>                 URL: https://issues.apache.org/jira/browse/HIVE-2578
>             Project: Hive
>          Issue Type: Bug
>            Reporter: Robert Surówka
>            Assignee: Robert Surówka
>            Priority: Minor
>         Attachments: HIVE-2578.1.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


Reply via email to