----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53111/ -----------------------------------------------------------
Review request for hive and Ashutosh Chauhan. Bugs: HIVE-14496 and HIVE-14497 https://issues.apache.org/jira/browse/HIVE-14496 https://issues.apache.org/jira/browse/HIVE-14497 Repository: hive-git Description ------- HIVE-14496: Enable Calcite rewriting with materialized views HIVE-14497: Fine control for using materialized views in rewriting Diffs ----- common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 6f168b57f1b06ab6c1e2fde708a3e7d8c9ee5434 hcatalog/core/src/test/java/org/apache/hive/hcatalog/common/TestHCatUtil.java 102d6d224af73f2799f3991b29e5a8695b80dd99 itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java 81ce67bdc8fdaf11ff4fec3f255ed0021a4752c7 itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/TestHiveMetaStore.java 21d1b46fcbd4f8f10ee447dce9d40dd6b43a2793 itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggrStatsCacheIntegration.java 51d96dd2ea02030860f4830a18d1f99d7592f11f itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/hbase/TestHBaseImport.java 21f851ef568bbf834b607498fc8b80d0511d7882 itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/hbase/TestHBaseSchemaTool.java b131163f6ca66be13c4b30686721f272049ecbb4 itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreIntegration.java 2cc1373108668b26e7e2a64cd5fff893159528bd itests/hive-unit/src/test/java/org/apache/hadoop/hive/metastore/hbase/TestStorageDescriptorSharing.java c29e46aaf91786cca267ab9c425fa50058189545 metastore/if/hive_metastore.thrift 42cb6f0de455793627a3c783d8b07c592adab7d7 metastore/scripts/upgrade/derby/037-HIVE-14496.derby.sql PRE-CREATION metastore/scripts/upgrade/derby/hive-schema-2.2.0.derby.sql ae980e0899df089fcfabc3a6190ef39444a6c2f5 metastore/scripts/upgrade/derby/upgrade-2.1.0-to-2.2.0.derby.sql 25a5e37c2708454388d1671c71a3474be3de4720 metastore/scripts/upgrade/mssql/022-HIVE-14496.mssql.sql PRE-CREATION metastore/scripts/upgrade/mssql/hive-schema-2.2.0.mssql.sql 8735b506f85e54bfcab7973984a37c2f24a2622b metastore/scripts/upgrade/mssql/upgrade-2.1.0-to-2.2.0.mssql.sql df972065ddef1d080872fef003d1b8665ba3f8a2 metastore/scripts/upgrade/mysql/037-HIVE-14496.mysql.sql PRE-CREATION metastore/scripts/upgrade/mysql/hive-schema-2.2.0.mysql.sql 91e221d8db06a098610b8c39cb664cb8d821e3d8 metastore/scripts/upgrade/mysql/upgrade-2.1.0-to-2.2.0.mysql.sql de38b58dbe0888f9daec0860c9d7ad055a5c5313 metastore/scripts/upgrade/oracle/037-HIVE-14496.oracle.sql PRE-CREATION metastore/scripts/upgrade/oracle/hive-schema-2.2.0.oracle.sql 39ba7cb3b5e8a68d6d2b543396306c7754a58070 metastore/scripts/upgrade/oracle/upgrade-2.1.0-to-2.2.0.oracle.sql 66784a4e0ec288364c9d44bf72261b6659b9d1a5 metastore/scripts/upgrade/postgres/036-HIVE-14496.postgres.sql PRE-CREATION metastore/scripts/upgrade/postgres/hive-schema-2.2.0.postgres.sql 63ac3befc2b465fd3d7e9c12a071d81c60dca86b metastore/scripts/upgrade/postgres/upgrade-2.1.0-to-2.2.0.postgres.sql 0b4591d5aabf25820c17bbe9ae625846e87f7265 metastore/src/gen/protobuf/gen-java/org/apache/hadoop/hive/metastore/hbase/HbaseMetastoreProto.java 9f2a88c443186fc0e93b11f432da8764fda80c46 metastore/src/gen/thrift/gen-cpp/ThriftHiveMetastore.cpp b4a05b2e61a4a5806a88e1894175132ceefe9901 metastore/src/gen/thrift/gen-cpp/hive_metastore_types.h 1252a2dd21a8e419439ed4b933e70a99aa93ba76 metastore/src/gen/thrift/gen-cpp/hive_metastore_types.cpp f3aaf7e0eec2b59dad1b5321ba4e77ca13ed46aa metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/Table.java 5d683fb615e28c79d01e6c15571332076bcbbef0 metastore/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/metastore/api/ViewDescriptor.java PRE-CREATION metastore/src/gen/thrift/gen-php/metastore/Types.php 61171c20e11b05db4fb4116413364c3b0e832572 metastore/src/gen/thrift/gen-py/hive_metastore/ttypes.py 879fc99a0ce2ab75c672b75c1e178c6f1d92ba82 metastore/src/gen/thrift/gen-rb/hive_metastore_types.rb cf644239af5f413b700d97f55c377785dec871fe metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 530d2f486de9ee92fc627404a3ae1ad086549e19 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStoreClient.java c32486fdd1c89e77d7a92740b0fa99738699e4de metastore/src/java/org/apache/hadoop/hive/metastore/IMetaStoreClient.java b77055905a04f010203cc6e07c525507e6d85a40 metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 90ea641c8d93c0126413bb2ac17190a05b231af8 metastore/src/java/org/apache/hadoop/hive/metastore/hbase/HBaseUtils.java 54daa4a4bdca8c22967e028f884e5cec3302a116 metastore/src/model/org/apache/hadoop/hive/metastore/model/MTable.java 2a78ce9c0cd5fa4501564ca4760cfca61630eeb7 metastore/src/model/org/apache/hadoop/hive/metastore/model/MViewDescriptor.java PRE-CREATION metastore/src/model/package.jdo bfd6dddcec3359faf3a02905638d4e02b6e11bb6 metastore/src/protobuf/org/apache/hadoop/hive/metastore/hbase/hbase_metastore_proto.proto 6fbe36cda755978a4f3d5e2143448b2268dc649e metastore/src/test/org/apache/hadoop/hive/metastore/TestHiveMetaStorePartitionSpecs.java 61fe7e1d917b51abf1c1ad800d0d8f517c95c0ad metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 04971591a68036cdc46c8755a063c32797dc4f8e metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCache.java 6cd3a4643b63660861fde2edf6f94e976b1142d5 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsCacheWithBitVector.java e0c4094fe3c4e963efbb3504d2a0e1a7d6e8ac98 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsExtrapolation.java f4e55ed612eb6344c3408a5beba48b7ae6e18df4 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseAggregateStatsNDVUniformDist.java 62918be10ce6fc693d994e25e7ad72ccefc647d5 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStore.java 4894ed3f3cf6947119f5342fbf8f177d87573395 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreBitVector.java b1dc542dffcaf4dd7d781c6acb5ed810f211bc40 metastore/src/test/org/apache/hadoop/hive/metastore/hbase/TestHBaseStoreCached.java cfe9cd04468c83f8edd2bff9fcb4dc667ff79298 ql/src/java/org/apache/hadoop/hive/ql/QueryState.java 78715d8fa489c2ae4b88302d97e70cfd9ea0117c ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java acf570f6db68b324c538c7d85c1569b7f19fd690 ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java dab4c6a10ac03724dab4b0d9f2d5e1eac9111c15 ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/metadata/Table.java ea908899a9f9145ff44e4dcb1a101696c596e442 ql/src/java/org/apache/hadoop/hive/ql/metadata/formatting/MetaDataFormatUtils.java c850e4347eed2312cbc31a467473eda9fdff0ff4 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/HiveRexExecutorImpl.java f7958c66b134925d4c5dc5676269c26bec602f67 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/RelOptHiveTable.java 73ca9bf05a9774f981153dc160d1619a06d68632 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveFilter.java 0410c91fa3e1755a4970e6c9d8552fa046d4f3db ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveJoin.java 0ad3e810755ea83020aa071f4e0627bc59d64232 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveProject.java 3e0a9a625375b5fdebdac1d5ecb6e20ba79c1ca2 ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveSemiJoin.java d8996671ebba72be3e46e6ab96413748d299732b ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveTableScan.java cccbd2f8d5281748f1a12ab244a1c1f2c321305c ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/HiveMaterializedViewFilterScanRule.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/MaterializedViewSubstitutionVisitor.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/views/SubstitutionVisitor.java PRE-CREATION ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java d32a0a7e72d01b1f288a146d3925781182277036 ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g 5c16c5584d7fd344852c768494fc87b7d513895b ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 9d58193636d4e09658f2de0a33b1848a0ef43736 ql/src/java/org/apache/hadoop/hive/ql/parse/StorageFormat.java d3b955c9eab96f58d0199b3903b77460a11af8e7 ql/src/java/org/apache/hadoop/hive/ql/plan/CreateViewDesc.java 6830bda66ced5e3c8522aae8c0ed33c9a3e05c0c ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 71aea3a12eff7e644eb6bef25d18eca754567e9a ql/src/test/queries/clientpositive/materialized_view_create_rewrite.q PRE-CREATION ql/src/test/results/clientnegative/alter_view_as_select_with_partition.q.out 4e43819a4b3dc89c4368b63bec2034a359d58d6b ql/src/test/results/clientpositive/alter_view_as_select.q.out dc1814e45ceae940c7d71ae38bbfb76f01a410db ql/src/test/results/clientpositive/create_or_replace_view.q.out f6f26d26cb97aec2e98b0d384026ea85d68f00a9 ql/src/test/results/clientpositive/create_view.q.out 12457b4a783d95f88d903b5083d4a684067c60ee ql/src/test/results/clientpositive/create_view_defaultformats.q.out dbc4a2086e879dc7bea1a54cfdab46c7d48e9e2d ql/src/test/results/clientpositive/create_view_partitioned.q.out 4373303c58d9429273f57de09c232e812f590f79 ql/src/test/results/clientpositive/create_view_translate.q.out 43b90621df2582e534e8746910df353cf7a50623 ql/src/test/results/clientpositive/cteViews.q.out 629178402910dde08602c3b6cfbcfdf80d737668 ql/src/test/results/clientpositive/escape_comments.q.out 0b8c5c521897ad5434adde36f3fe08b0a1c6149f ql/src/test/results/clientpositive/explain_ddl.q.out e8438a132ce0b998baccef9de940e3cdf9ca6356 ql/src/test/results/clientpositive/llap/cbo_rp_unionDistinct_2.q.out 304d74f40d314a06d20180255d87796bcad9f4a3 ql/src/test/results/clientpositive/llap/selectDistinctStar.q.out 985086d86344d25275068f8ae94a85197b2aa929 ql/src/test/results/clientpositive/llap/subquery_views.q.out 35e80aea93d38689f99c3ce4607a1adf43e6bcdb ql/src/test/results/clientpositive/llap/unionDistinct_2.q.out 304d74f40d314a06d20180255d87796bcad9f4a3 ql/src/test/results/clientpositive/llap/union_top_level.q.out b4e4d9345a539d3b6689b177767adb7af8aea2dd ql/src/test/results/clientpositive/materialized_view_create_rewrite.q.out PRE-CREATION ql/src/test/results/clientpositive/materialized_view_describe.q.out 57141980598eb547fa2f1b6c8e254b4cfc8bfbc2 ql/src/test/results/clientpositive/spark/union_top_level.q.out e1c7fc740a4319bcb5cbd4d05fa288bf35c515cc ql/src/test/results/clientpositive/subquery_views.q.out 610bf245cfc25a54843ffe72b44c7ea01ca4d9e8 ql/src/test/results/clientpositive/tez/unionDistinct_2.q.out 304d74f40d314a06d20180255d87796bcad9f4a3 ql/src/test/results/clientpositive/unicode_comments.q.out 4872cd3809a34b91c18e891cb87fb5f3becaa4ab ql/src/test/results/clientpositive/view_alias.q.out 78ff5e2d7c07c16a63be05095d3eda2ed35e9ca8 service/src/java/org/apache/hive/service/cli/session/HiveSessionImpl.java 8051f47f7ff8ea0d139f04132a18140053efa6b2 Diff: https://reviews.apache.org/r/53111/diff/ Testing ------- Thanks, Jesús Camacho Rodríguez