----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53570/ -----------------------------------------------------------
Review request for hive, Reuben Kuhnert and Sergio Pena. Repository: hive-git Description ------- HIVE-12891 : Hive fails when java.io.tmpdir is set to a relative location This is a continuation of this review request: https://reviews.apache.org/r/42726/ I had a look at the comment, but I think calling makeAbsolute() directly in SystemVariables is not that nice. The variable value is not necessarily a path, so we would need to test for that first, and I don't think we need/should convert every path of every variable. The current solution only converts the relative path for the java.io.tmpdir and nothing else. Diffs ----- common/src/java/org/apache/hadoop/hive/common/FileUtils.java 1d734f9860311cb3832c8356ddd6f8ed4a6465c5 common/src/java/org/apache/hadoop/hive/conf/SystemVariables.java 9f59f11ca6459853b15ca80fa9751db934befc71 common/src/java/org/apache/hadoop/hive/conf/valcoersion/JavaIOTmpdirVariableCoercion.java PRE-CREATION common/src/java/org/apache/hadoop/hive/conf/valcoersion/VariableCoercion.java PRE-CREATION common/src/test/org/apache/hadoop/hive/common/TestFileUtils.java c02217ae48176f5d4869cd21cd1a27678f2ded45 common/src/test/org/apache/hadoop/hive/conf/TestSystemVariables.java PRE-CREATION Diff: https://reviews.apache.org/r/53570/diff/ Testing ------- Tested that if -Djava.io.tmpdir is set to a relative path we can still connect using beeline and run queries. Added and ran unit tests. Thanks, Barna Zsombor Klara
