[
https://issues.apache.org/jira/browse/HIVE-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13150853#comment-13150853
]
jirapos...@reviews.apache.org commented on HIVE-2573:
-----------------------------------------------------
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2831/#review3281
-----------------------------------------------------------
Looks good overall, but I think we should continue to require that the user
specify the TEMPORARY keyword until we have a security mechanism in place to
restrict access to non-temporary functions.
ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java
<https://reviews.apache.org/r/2831/#comment7343>
Please don't move blocks of code around. It makes the diffs much harder to
review. Please save cleanup/reorganization changes like this for refactoring
patches.
ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g
<https://reviews.apache.org/r/2831/#comment7344>
Since we don't yet have the security mechanism in place to handle global
non-temporary functions, I think we should leave the grammar unchanged and
continue to require that the user specify the "TEMPORARY" keyword. Please back
out this change, along with the modifications to CreateFuncDesc and
DropFuncDesc.
ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java
<https://reviews.apache.org/r/2831/#comment7345>
Please prefix boolean variable names with "is", e.g. "isTemporary".
- Carl
On 2011-11-15 07:06:04, Navis Ryu wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/2831/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-11-15 07:06:04)
bq.
bq.
bq. Review request for hive and Carl Steinbach.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. Extension from HIVE-2503 for function registry.
bq.
bq.
bq. This addresses bug HIVE-2573.
bq. https://issues.apache.org/jira/browse/HIVE-2573
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. ql/src/java/org/apache/hadoop/hive/ql/parse/Hive.g 4d4fce2
bq. ql/src/java/org/apache/hadoop/hive/ql/plan/CreateFunctionDesc.java
051095a
bq. ql/src/java/org/apache/hadoop/hive/ql/plan/DropFunctionDesc.java 8a78f5b
bq. ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java 07a4832
bq. ql/src/test/org/apache/hadoop/hive/ql/QTestUtil.java 35d124b
bq. ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 197bc77
bq. ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionTask.java 70b6f57
bq.
ql/src/java/org/apache/hadoop/hive/ql/parse/FunctionSemanticAnalyzer.java
f2b7018
bq.
bq. Diff: https://reviews.apache.org/r/2831/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq.
bq. Thanks,
bq.
bq. Navis
bq.
bq.
> Create per-session function registry
> -------------------------------------
>
> Key: HIVE-2573
> URL: https://issues.apache.org/jira/browse/HIVE-2573
> Project: Hive
> Issue Type: Improvement
> Components: Server Infrastructure
> Reporter: Navis
> Priority: Minor
> Attachments: HIVE-2573.1.patch.txt, HIVE-2573.2.patch.txt,
> HIVE-2573.3.patch.txt
>
>
> Currently the function registry is shared resource and could be overrided by
> other users when using HiveServer. If per-session function registry is
> provided, this situation could be prevented.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
