> On Nov. 22, 2016, 9:27 p.m., Yongzhi Chen wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java, line 2983 > > <https://reviews.apache.org/r/53966/diff/2/?file=1568277#file1568277line2983> > > > > if (isBlobStoragePath && !destFs.exists(destFilePath) > > then the second condition : > > !destFs.rename(sourcePath, destFilePath) will be evaluated. I assume > > you do not want that be called, right
I wanted to be called. For HDFS, the rename() will return 'false' if the destination file already exists, but in S3, the rename will return 'true' even if the file already exists, so that's why I use 'exists' for S3 only. - Sergio ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/53966/#review156639 ----------------------------------------------------------- On Nov. 21, 2016, 11:54 p.m., Sergio Pena wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/53966/ > ----------------------------------------------------------- > > (Updated Nov. 21, 2016, 11:54 p.m.) > > > Review request for hive. > > > Bugs: HIVE-15199 > https://issues.apache.org/jira/browse/HIVE-15199 > > > Repository: hive-git > > > Description > ------- > > The patch helps execute repeated INSERT INTO statements on S3 tables when the > scratch directory is on S3. > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java > 1d8c04160c35e48781b20f8e6e14760c19df9ca5 > itests/hive-blobstore/src/test/queries/clientpositive/insert_into.q > 919ff7d9c7cb40062d68b876d6acbc8efb8a8cf1 > itests/hive-blobstore/src/test/results/clientpositive/insert_into.q.out > c25d0c4eec6983b6869e2eba711b39ba91a4c6e0 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > 61b8bd0ac40cffcd6dca0fc874940066bc0aeffe > > Diff: https://reviews.apache.org/r/53966/diff/ > > > Testing > ------- > > > Thanks, > > Sergio Pena > >
