> On Dec. 2, 2016, 8:58 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java, > > line 101 > > <https://reviews.apache.org/r/54313/diff/1/?file=1574845#file1574845line101> > > > > Was this just an oversight earlier?
It was exactly that; we might end up calling fallback twice and it was causing an Exception to be thrown. - Jesús ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/54313/#review157792 ----------------------------------------------------------- On Dec. 2, 2016, 5:24 p.m., Jesús Camacho Rodríguez wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/54313/ > ----------------------------------------------------------- > > (Updated Dec. 2, 2016, 5:24 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-15251 > https://issues.apache.org/jira/browse/HIVE-15251 > > > Repository: hive-git > > > Description > ------- > > HIVE-15251 > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties > e4910e4cda49bc3684e7b9ae5aa0607bd16a0a07 > ql/src/java/org/apache/hadoop/hive/ql/ErrorMsg.java > b62df35cdddc346d0e5d034b10f7b91f9d17d804 > ql/src/java/org/apache/hadoop/hive/ql/exec/CommonJoinOperator.java > 5512ee27ce04bb36596288d42281b081ba290d7b > ql/src/java/org/apache/hadoop/hive/ql/exec/JoinUtil.java > 6cbcab699141ec143053e6ee3e2d60e93eeeb71a > ql/src/java/org/apache/hadoop/hive/ql/optimizer/ConvertJoinMapJoin.java > 2b93e01f36f185ba755bacda89b081fe6286a9ab > ql/src/java/org/apache/hadoop/hive/ql/optimizer/MapJoinProcessor.java > c6efd5b21dcf2633ec027ced952fe4b04621d9d4 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > 37baaf694c314a1377ded9b337b785c8c5c783e5 > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java > d55db0accf430724b51a8704838964688a5221ec > ql/src/java/org/apache/hadoop/hive/ql/plan/JoinDesc.java > 2ca6b8f1c5a2ad8c586e26d1cbf70d6f1680ebf0 > ql/src/test/queries/clientpositive/join46.q PRE-CREATION > ql/src/test/queries/clientpositive/mapjoin46.q PRE-CREATION > ql/src/test/queries/clientpositive/smb_mapjoin_46.q PRE-CREATION > ql/src/test/queries/clientpositive/vectorized_join46.q PRE-CREATION > ql/src/test/results/clientpositive/join46.q.out PRE-CREATION > ql/src/test/results/clientpositive/llap/join46.q.out PRE-CREATION > ql/src/test/results/clientpositive/llap/mapjoin46.q.out PRE-CREATION > ql/src/test/results/clientpositive/llap/vectorized_join46.q.out > PRE-CREATION > ql/src/test/results/clientpositive/mapjoin46.q.out PRE-CREATION > ql/src/test/results/clientpositive/smb_mapjoin_46.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/54313/diff/ > > > Testing > ------- > > > Thanks, > > Jesús Camacho Rodríguez > >
