----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55154/#review160447 -----------------------------------------------------------
metastore/src/java/org/apache/hadoop/hive/metastore/messaging/InsertMessage.java (line 58) <https://reviews.apache.org/r/55154/#comment231590> Rather than a List<byte[]> getFileChecksums, I was really visualizing a List<String> getFiles(), where each file listed is a URI that has the checksum encoded into it. The reason is that a list of checksums is too highly bound to our replication usecase only, and has nothing to do with a more generic "Message" that could be used for other purposes as well. Messages are currently used for things like audit as well, and not just replication. Having the checksums coded in the URLs makes the message interface consistent without knowing more on how to actually read the url. metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONInsertMessage.java (line 115) <https://reviews.apache.org/r/55154/#comment231591> Same comment as with InsertMessage - this should not be a list of checksums but a list of pathnames (urls) ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java <https://reviews.apache.org/r/55154/#comment231592> removing this is incorrect and breaks current EXPORT in replv1 - this is used to basically noop-out things like non-storagehandler based tables, views, etc. - Sushanth Sowmyan On Jan. 3, 2017, 10:27 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55154/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2017, 10:27 p.m.) > > > Review request for hive, Daniel Dai, Sushanth Sowmyan, and Thejas Nair. > > > Bugs: HIVE-15366 > https://issues.apache.org/jira/browse/HIVE-15366 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-15366 > > > Diffs > ----- > > > metastore/src/java/org/apache/hadoop/hive/metastore/messaging/InsertMessage.java > fe747df > > metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONInsertMessage.java > bd9f9ec > > metastore/src/java/org/apache/hadoop/hive/metastore/messaging/json/JSONMessageFactory.java > 9954902 > ql/src/java/org/apache/hadoop/hive/ql/exec/ReplCopyTask.java 4c0f817 > ql/src/java/org/apache/hadoop/hive/ql/parse/EximUtil.java 6e9602f > ql/src/java/org/apache/hadoop/hive/ql/parse/ExportSemanticAnalyzer.java > f61274b > ql/src/java/org/apache/hadoop/hive/ql/parse/ImportSemanticAnalyzer.java > 5561e06 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ReplicationSemanticAnalyzer.java > 9b83407 > > Diff: https://reviews.apache.org/r/55154/diff/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >