----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/55731/#review162357 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (line 3645) <https://reviews.apache.org/r/55731/#comment233713> If it is for user update stats, you will have StatsSetupConst.STATS_GENERATED = StatsSetupConst.USER automatically. Thus it is not necessary to have/call hasStatsInParameters function. ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (line 3655) <https://reviews.apache.org/r/55731/#comment233714> The same as above ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (line 3657) <https://reviews.apache.org/r/55731/#comment233715> And, could u just remove the property rather than set it to false? We treat the missing of the property the same as set it to false. ql/src/test/queries/clientpositive/alter_table_stats_status.q (line 1) <https://reviews.apache.org/r/55731/#comment233718> Could u add some more test cases for partition stats? Thanks. - pengcheng xiong On Jan. 19, 2017, 10:29 p.m., Chaoyu Tang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/55731/ > ----------------------------------------------------------- > > (Updated Jan. 19, 2017, 10:29 p.m.) > > > Review request for hive and pengcheng xiong. > > > Bugs: HIVE-15653 > https://issues.apache.org/jira/browse/HIVE-15653 > > > Repository: hive-git > > > Description > ------- > > For most of alter table operations like table rename, add columns, change > column type etc (besides the set table properties), the table stats status > should not change. But for some other operations like update statistics, > change location, the basic stats status should change. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java a1fb874 > ql/src/test/queries/clientpositive/alter_table_stats_status.q PRE-CREATION > ql/src/test/results/clientpositive/alter_table_stats_status.q.out > PRE-CREATION > > Diff: https://reviews.apache.org/r/55731/diff/ > > > Testing > ------- > > 1. Manual tests > 2. new unit tests > > > Thanks, > > Chaoyu Tang > >
