-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55977/#review163695
-----------------------------------------------------------




llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java
 (line 175)
<https://reviews.apache.org/r/55977/#comment235170>

    nit: typo VertorDeserializeOrcWriter
    Is the renaming happening elsewhere?



llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java
 (line 1489)
<https://reviews.apache.org/r/55977/#comment235608>

    nit: typo



orc/src/java/org/apache/orc/impl/TreeReaderFactory.java (line 169)
<https://reviews.apache.org/r/55977/#comment235610>

    create ORC jira?



orc/src/java/org/apache/orc/impl/WriterImpl.java (line 2323)
<https://reviews.apache.org/r/55977/#comment235611>

    seems not required. where is the dereference happening?


- Prasanth_J


On Feb. 1, 2017, 3:34 a.m., Sergey Shelukhin wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55977/
> -----------------------------------------------------------
> 
> (Updated Feb. 1, 2017, 3:34 a.m.)
> 
> 
> Review request for hive, Gopal V and Prasanth_J.
> 
> 
> Repository: hive-git
> 
> 
> Description
> -------
> 
> see jira
> 
> 
> Diffs
> -----
> 
>   common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a2ec1f0 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/cache/SerDeLowLevelCacheImpl.java
>  85fae9a 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java
>  d0e70d1 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/SerDeEncodedDataReader.java
>  9ab26e6 
>   
> llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/VertorDeserializeOrcWriter.java
>  98fc9df 
>   orc/src/java/org/apache/orc/impl/TreeReaderFactory.java 8b097ba 
>   orc/src/java/org/apache/orc/impl/WriterImpl.java b1f3cfb 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 6281edd 
>   
> ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java
>  0dba1a0 
>   ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java 1c5f0e6 
>   
> storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java
>  b894c11e 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/BytesColumnVector.java
>  552982c 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/ColumnVector.java 
> 6f090a1 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/DecimalColumnVector.java
>  e4f8d82 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/DoubleColumnVector.java
>  bd421f4 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/IntervalDayTimeColumnVector.java
>  c4a6c0f 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/LongColumnVector.java
>  80d4731 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/MultiValuedColumnVector.java
>  1aeff83 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/StructColumnVector.java
>  cf07bca 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/TimestampColumnVector.java
>  28997a0 
>   
> storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/UnionColumnVector.java
>  0c61243 
> 
> Diff: https://reviews.apache.org/r/55977/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Sergey Shelukhin
> 
>

Reply via email to