-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/56290/#review164491
-----------------------------------------------------------
Hi,
Thanks for the patch.
I am not an expert on Accumulo, so I leave the review of the patch for the ones
who know it more, but working on adding Yetus as a pre-commit test
(HIVE-15051), and run it on your patch.
It has returned the following warnings:
- Checkstyle:
./accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloDefaultIndexScanner.java:40:/**:
warning: First sentence should end with a period.
./accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloDefaultIndexScanner.java:63:
protected AccumuloConnectionParameters connectParams;:42: warning: Variable
'connectParams' must be private and have accessor methods.
./accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloDefaultIndexScanner.java:64:
protected AccumuloIndexParameters indexParams;:37: warning: Variable
'indexParams' must be private and have accessor methods.
./accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloDefaultIndexScanner.java:65:
protected int maxRowIds;:17: warning: Variable 'maxRowIds' must be private
and have accessor methods.
./accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloDefaultIndexScanner.java:66:
protected Authorizations auths;:28: warning: Variable 'auths' must be private
and have accessor methods.
./accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloDefaultIndexScanner.java:67:
protected String indexTable;:20: warning: Variable 'indexTable' must be
private and have accessor methods.
./accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloDefaultIndexScanner.java:68:
protected Set<String> indexColumns;:25: warning: Variable 'indexColumns' must
be private and have accessor methods.
./accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/AccumuloRangeGenerator.java:62:
protected AccumuloIndexScanner indexScanner;:34: warning: Variable
'indexScanner' must be private and have accessor methods.
./accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/AccumuloRangeGenerator.java:248:
}: warning: method def rcurly at indentation level 4 not at correct
indentation, 2
- Javac warnings:
[WARNING]
/Users/petervary/dev/upstream/hive/accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexParameters.java:
/Users/petervary/dev/upstream/hive/accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexParameters.java
uses unchecked or unsafe operations.
[WARNING]
/Users/petervary/dev/upstream/hive/accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexParameters.java:
Recompile with -Xlint:unchecked for details.
[WARNING]
/Users/petervary/dev/upstream/hive/accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloRangeGenerator.java:
/Users/petervary/dev/upstream/hive/accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloRangeGenerator.java
uses unchecked or unsafe operations.
[WARNING]
/Users/petervary/dev/upstream/hive/accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloRangeGenerator.java:
Recompile with -Xlint:unchecked for details.
Thanks,
Peter
- Peter Vary
On Feb. 6, 2017, 4:51 p.m., Mike Fagan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/56290/
> -----------------------------------------------------------
>
> (Updated Feb. 6, 2017, 4:51 p.m.)
>
>
> Review request for hive.
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-15795: Add Accumulo Index Table Support
>
>
> Diffs
> -----
>
>
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloDefaultIndexScanner.java
> PRE-CREATION
>
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexParameters.java
> PRE-CREATION
>
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/AccumuloIndexScanner.java
> PRE-CREATION
>
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/AccumuloPredicateHandler.java
> a7ec7c5
>
> accumulo-handler/src/java/org/apache/hadoop/hive/accumulo/predicate/AccumuloRangeGenerator.java
> 21392d1
>
> accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloDefaultIndexScanner.java
> PRE-CREATION
>
> accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/TestAccumuloIndexParameters.java
> PRE-CREATION
>
> accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloPredicateHandler.java
> 88e4530
>
> accumulo-handler/src/test/org/apache/hadoop/hive/accumulo/predicate/TestAccumuloRangeGenerator.java
> 339da07
>
> Diff: https://reviews.apache.org/r/56290/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Mike Fagan
>
>
