> On Feb. 17, 2017, 11:04 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java, line 347 > > <https://reviews.apache.org/r/56775/diff/2/?file=1639283#file1639283line347> > > > > remove
Will remove when it's ready to commit :) > On Feb. 17, 2017, 11:04 p.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java, line 351 > > <https://reviews.apache.org/r/56775/diff/2/?file=1639283#file1639283line351> > > > > This may traverse full tree if SETCOLREF is not present in AST, which > > will be a common case. That could be expensive. replaced with slightly cheaper search - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56775/#review165988 ----------------------------------------------------------- On Feb. 17, 2017, 11:10 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56775/ > ----------------------------------------------------------- > > (Updated Feb. 17, 2017, 11:10 p.m.) > > > Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/Driver.java 2423471 > > ql/src/java/org/apache/hadoop/hive/ql/metadata/HiveMaterializedViewsRegistry.java > 89c87cd > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/ASTBuilder.java > e36e1bd > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/index/RewriteParseContextGenerator.java > 340d29a > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java e7687be > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsAutoGatherContext.java > 80e62c1 > > ql/src/java/org/apache/hadoop/hive/ql/parse/ColumnStatsSemanticAnalyzer.java > ff07b42 > ql/src/java/org/apache/hadoop/hive/ql/parse/HiveParser.g eb81393 > ql/src/java/org/apache/hadoop/hive/ql/parse/ParseUtils.java 943e6af > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java f053093 > > ql/src/java/org/apache/hadoop/hive/ql/parse/UpdateDeleteSemanticAnalyzer.java > 12a43a2 > ql/src/java/org/apache/hadoop/hive/ql/tools/LineageInfo.java 12154c9 > ql/src/test/org/apache/hadoop/hive/ql/parse/TestMacroSemanticAnalyzer.java > c659806 > > ql/src/test/org/apache/hadoop/hive/ql/parse/TestUpdateDeleteSemanticAnalyzer.java > d6fe540 > > ql/src/test/org/apache/hadoop/hive/ql/parse/authorization/AuthorizationTestUtil.java > e8e29ee > ql/src/test/queries/clientpositive/union_pos_alias.q PRE-CREATION > ql/src/test/results/clientpositive/constant_prop_1.q.out aaa1dac > ql/src/test/results/clientpositive/union_pos_alias.q.out PRE-CREATION > > Diff: https://reviews.apache.org/r/56775/diff/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
