----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56546/#review166239 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java (line 1207) <https://reviews.apache.org/r/56546/#comment238143> Should the command like 'alter table add column' always alter the avro schema? Just wondering if it's necessary to add this configuration. So what we will do is to update the schema file? ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (line 3561) <https://reviews.apache.org/r/56546/#comment238145> I guess it's for performance reason that we are not getting sd all the time since for some following cases, probably sd is not used. Can you double check? ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java (line 3568) <https://reviews.apache.org/r/56546/#comment238150> This is avro specific call. I'm wondering if we can achieve this by something like, giving SerDe a function handleAddColumn(). Not sure if it makes sense. Can you take a look? ql/src/test/queries/clientpositive/avro_add_column_extschema.q (line 27) <https://reviews.apache.org/r/56546/#comment238151> Can you also print out show create table? I'm wondering if the schema literal gets updated? And also if we use avro.schema.url instead of literal, will it work as well? - Aihua Xu On Feb. 21, 2017, 9:52 p.m., Adam Szita wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56546/ > ----------------------------------------------------------- > > (Updated Feb. 21, 2017, 9:52 p.m.) > > > Review request for hive, Aihua Xu, Peter Vary, and Sergio Pena. > > > Bugs: HIVE-13780 > https://issues.apache.org/jira/browse/HIVE-13780 > > > Repository: hive-git > > > Description > ------- > > Allow user to update AVRO table schema via command even if table's definition > was defined through schema file / literal in tblproperties > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > b27b663b94f41a8250b79139ed9f7275b10cf9a3 > ql/src/java/org/apache/hadoop/hive/ql/exec/DDLTask.java > adabe70fa8f0fe1b990c6ac578a14ff5af06fc93 > ql/src/test/queries/clientnegative/avro_add_column_extschema.q PRE-CREATION > ql/src/test/queries/clientpositive/avro_add_column_extschema.q PRE-CREATION > ql/src/test/results/clientnegative/avro_add_column_extschema.q.out > PRE-CREATION > ql/src/test/results/clientpositive/avro_add_column_extschema.q.out > PRE-CREATION > serde/src/java/org/apache/hadoop/hive/serde2/avro/AvroSerdeUtils.java > f18585da1d108abdd500437362eb388b21030ec7 > > Diff: https://reviews.apache.org/r/56546/diff/ > > > Testing > ------- > > > Thanks, > > Adam Szita > >
