----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57626/ -----------------------------------------------------------
Review request for hive. Bugs: HIVE-16164 https://issues.apache.org/jira/browse/HIVE-16164 Repository: hive-git Description ------- This fix updates the EnvironmentContext with a DB_NOTIFICATION_EVENT_ID property from withing the DbNotificationListener class. It then passes the EnvironmentContext from transactional listeners to non-transactional listeners so that the eventId is shared between them. The patch provides the following changes: - DbNotificationListener Changes to pass the EnvironmentContext from transactional to non-transactional listeners. - HiveAlterHandler Changes to pass the EnvironmentContext from transactional to non-transactional listeners. - MetaStoreListenerNotifier New helper class that wraps the notification call to the listeners. - TestObjectStore Verifies that the addNotificationEvent() method saves the eventId on the NotificationEvent object. - TestDbNotificationListener Verifies that any HMS call is passing the DB_NOTIFICATION_EVENT_ID to non-transactional listeners. Diffs ----- hcatalog/server-extensions/src/main/java/org/apache/hive/hcatalog/listener/DbNotificationListener.java f7e3e3a0a71094992fdf4bd3ceea2da0bf7d1ff0 itests/hcatalog-unit/src/test/java/org/apache/hive/hcatalog/listener/TestDbNotificationListener.java 1cf47c36cb490ce0b17ffe312cd2e9fc4bb7cd9a metastore/src/java/org/apache/hadoop/hive/metastore/HiveAlterHandler.java bae39acafeb86d04ac8ec66098be125cd3cef3e0 metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java 07eca38190c1b05bb4a3977e9154423449828957 metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreListenerNotifier.java PRE-CREATION metastore/src/test/org/apache/hadoop/hive/metastore/TestObjectStore.java 1f87eeb18f6edf7351b3c8da6a6826c08656e48c Diff: https://reviews.apache.org/r/57626/diff/1/ Testing ------- HiveQA showed only one test failure. it is fixed, and waiting for HiveQA to complete 100% tests. Thanks, Sergio Pena