> On March 15, 2017, 12:56 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/NamedJoinInfo.java > > Lines 25 (patched) > > <https://reviews.apache.org/r/57620/diff/1/?file=1664809#file1664809line25> > > > > Better name: NamedColInJoin.
I think NamedJoinInfo is more appropriate because this class contains not only named column but also other information, e.g., table aliases and join type. > On March 15, 2017, 12:56 a.m., Ashutosh Chauhan wrote: > > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java > > Lines 1949 (patched) > > <https://reviews.apache.org/r/57620/diff/1/?file=1664810#file1664810line1949> > > > > Error message: Atleast one column is expected in using() Found: 0. I have a second thought. It is impossible to have 0 columns as the parser will prevent user from doing so. - pengcheng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/57620/#review168961 ----------------------------------------------------------- On March 14, 2017, 8:43 p.m., pengcheng xiong wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/57620/ > ----------------------------------------------------------- > > (Updated March 14, 2017, 8:43 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > HIVE-15983 > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/exec/NamedJoinInfo.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java bf0a11b > ql/src/java/org/apache/hadoop/hive/ql/parse/FromClauseParser.g 558ca7f > ql/src/java/org/apache/hadoop/hive/ql/parse/RowResolver.java e14f1cf > ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 0732207 > ql/src/test/queries/clientpositive/named_column_join.q PRE-CREATION > ql/src/test/results/clientpositive/named_column_join.q.out PRE-CREATION > > > Diff: https://reviews.apache.org/r/57620/diff/1/ > > > Testing > ------- > > > Thanks, > > pengcheng xiong > >
