----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/56763/#review169276 -----------------------------------------------------------
Huhhh.. this is starting to get too long... I hope you do not mind my nitpicking Thanks for your patience, Peter itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java Lines 2886 (patched) <https://reviews.apache.org/r/56763/#comment241627> This assertion will fail, since the URL will contain the key "hive.conf.hidden.list" since only the value is anonymized. hiddenConf will be "hidden" which will match the URL. To tell the truth, I run the tests and found out about it only when there was a failure :) - Peter Vary On March 17, 2017, 9:14 a.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/56763/ > ----------------------------------------------------------- > > (Updated March 17, 2017, 9:14 a.m.) > > > Review request for hive, Peter Vary and Thejas Nair. > > > Bugs: HIVE-15931 > https://issues.apache.org/jira/browse/HIVE-15931 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-15931 > > > Diffs > ----- > > beeline/src/java/org/apache/hive/beeline/Commands.java 99ee82c > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestJdbcDriver2.java > 4a82aa5 > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java 1695c5d > jdbc/src/java/org/apache/hive/jdbc/HiveDriver.java a349f8b > jdbc/src/java/org/apache/hive/jdbc/Utils.java bfae8b9 > jdbc/src/java/org/apache/hive/jdbc/ZooKeeperHiveClientHelper.java 8d6003a > jdbc/src/test/org/apache/hive/jdbc/TestJdbcDriver.java 162e42f > > > Diff: https://reviews.apache.org/r/56763/diff/6/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
