----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58456/ -----------------------------------------------------------
Review request for hive, Aihua Xu, Chaoyu Tang, and Sergio Pena. Bugs: HIVE-16426 https://issues.apache.org/jira/browse/HIVE-16426 Repository: hive-git Description ------- 1. Use threadlocal variable to store cancel state to make it is accessible without being passed around by parameters. 2. Add checkpoints for file operations. 3. Remove backgroundHandle.cancel to avoid failed file cleanup because of the interruption. By what I observed that the method seems not very effective for scheduled operation, for example, the on going HMS API calls. Diffs ----- ql/src/java/org/apache/hadoop/hive/ql/Driver.java a80004662068eb2391c0dd7062f77156b222375b ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java b0657f01d4482dc8bb8dc180e5e7deffbdb533e6 ql/src/java/org/apache/hadoop/hive/ql/io/CombineHiveInputFormat.java 7a113bf8e5c4dd8c2c486741a5ebc7b8940e746b service/src/java/org/apache/hive/service/cli/operation/SQLOperation.java 04fc0a17c93120b8f6e6d7c36e4d70631d56baca Diff: https://reviews.apache.org/r/58456/diff/1/ Testing ------- Manually tested. Thanks, Yongzhi Chen