----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58865/#review173407 -----------------------------------------------------------
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java Lines 3341 (patched) <https://reviews.apache.org/r/58865/#comment246405> nit: add new line after "may have." nit: maximu -> maximum ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java Lines 135 (patched) <https://reviews.apache.org/r/58865/#comment246406> Maybe also log the actual limit number? ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RemoteSparkJobMonitor.java Lines 106 (patched) <https://reviews.apache.org/r/58865/#comment246407> Maybe we should skip counting this if `sparkJobMaxTaskCount` is -1? ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RemoteSparkJobMonitor.java Lines 106 (patched) <https://reviews.apache.org/r/58865/#comment246590> Also, we don't need to compute this if `sparkJobMaxTaskCount` is -1. - Chao Sun On May 1, 2017, 5:13 p.m., Xuefu Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58865/ > ----------------------------------------------------------- > > (Updated May 1, 2017, 5:13 p.m.) > > > Review request for hive. > > > Bugs: HIVE-16552 > https://issues.apache.org/jira/browse/HIVE-16552 > > > Repository: hive-git > > > Description > ------- > > See JIRA description > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java d3ea824 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java 32a7730 > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/RemoteSparkJobMonitor.java > dd73f3e > > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/status/SparkJobMonitor.java > 0b224f2 > > > Diff: https://reviews.apache.org/r/58865/diff/2/ > > > Testing > ------- > > Test locally > > > Thanks, > > Xuefu Zhang > >
