----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60478/#review179053 -----------------------------------------------------------
Looks good to me. Can you please address one minor comment? llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java Lines 183 (patched) <https://reviews.apache.org/r/60478/#comment253457> Why is this code block commented out? Is it not needed anymore? - Deepak Jaiswal On June 27, 2017, 6:24 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60478/ > ----------------------------------------------------------- > > (Updated June 27, 2017, 6:24 p.m.) > > > Review request for hive and Deepak Jaiswal. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties 0aadee3e3d > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java > c22d446320 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java > d4e14a88c2 > > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatchCtx.java > e546a658c7 > ql/src/test/queries/clientpositive/llap_smb.q PRE-CREATION > ql/src/test/results/clientpositive/llap/llap_smb.q.out PRE-CREATION > > > Diff: https://reviews.apache.org/r/60478/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
