----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60355/#review179085 -----------------------------------------------------------
Sorry for getting back this late and thank you for the updates. I don't want to be too nitpicky but I did have another comment about rewording a log line, sorry. As for testing, you do have jars on the classpath during testing. So for example you can be pretty sure that the junit jar will be on your classpath somewhere, and you could write tests against ClassUtil using the junit packages. But the patch LGTM. ql/src/java/org/apache/hadoop/hive/ql/util/ClassUtil.java Lines 85 (patched) <https://reviews.apache.org/r/60355/#comment253520> Nit: I think what you meant should be one of the following: - Exception occured while executing getJarFile - Exception occured during the execution of getJarFile - getJarFile encountered an exception Same on line 90. - Barna Zsombor Klara On June 23, 2017, 3:56 a.m., ZhangBing Lin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60355/ > ----------------------------------------------------------- > > (Updated June 23, 2017, 3:56 a.m.) > > > Review request for hive, cheng xu and Xuefu Zhang. > > > Bugs: HIVE-16929 > https://issues.apache.org/jira/browse/HIVE-16929 > > > Repository: hive-git > > > Description > ------- > > Add a configuration item "hive.aux.udf.package.name.list" in hive-site.xml, > which is a scan corresponding to the $HIVE_HOME/auxlib/ directory jar package > that contains the corresponding configuration package name under the class > registered as a constant function. > Such as, > <property> > <name>hive.aux.udf.package.name.list</name> > <value>com.sample.udf,com.test.udf</value> > </property> > Instructions: > 1, upload your jar file to $ HIVE_HOME/auxlib > 2, configure your UDF function corresponding to the package to the > following configuration parameters > <property> > <name>hive.aux.udf.package.name.list</name> > <value>com.sample.udf</value> > </property> > > 3, the configuration items need to be placed in the hive-site.xml file > 4, restart the Hive service to take effect > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java a8bdefdad6 > ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 9795f3ef98 > ql/src/java/org/apache/hadoop/hive/ql/util/ClassUtil.java PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/util/UDFRegister.java PRE-CREATION > > > Diff: https://reviews.apache.org/r/60355/diff/4/ > > > Testing > ------- > > > Thanks, > > ZhangBing Lin > >
