----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/60589/#review179498 -----------------------------------------------------------
LGTM +1 Only one little wish, but the patch is still good without it :) ql/src/test/queries/clientpositive/insert_overwrite_table.q Lines 2 (patched) <https://reviews.apache.org/r/60589/#comment254239> Would you mind renaming the location more test specific, like '${system:test.tmp.dir}/inser_overwrite_table_test'? It is perfectly good as it is, but I would be able to run most of the tests parallel with BeeLineDriver, and it might cause problems, if other test might use the same directory. To reiterate - the patch is perfectly good as it is, since it will run with the current fremeworks and we might tackle this problem anyway when we change the BeeLine tests. - Peter Vary On July 3, 2017, 9:05 a.m., Barna Zsombor Klara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/60589/ > ----------------------------------------------------------- > > (Updated July 3, 2017, 9:05 a.m.) > > > Review request for hive. > > > Repository: hive-git > > > Description > ------- > > HIVE-17001: Insert overwrite table doesn't clean partition directory on HDFS > if partition is missing from HMS > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > 73710a7c2917b5268f788f22baaee2d87846961b > ql/src/test/queries/clientpositive/insert_overwrite_table.q PRE-CREATION > ql/src/test/results/clientpositive/insert_overwrite_table.q.out > PRE-CREATION > > > Diff: https://reviews.apache.org/r/60589/diff/1/ > > > Testing > ------- > > Manual testing and qtests. > > > Thanks, > > Barna Zsombor Klara > >
