> On July 7, 2017, 8:54 p.m., Vaibhav Gumashta wrote: > >
Also, can you comment on the testing of this? - Vaibhav ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/58403/#review179940 ----------------------------------------------------------- On April 19, 2017, 6:48 a.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/58403/ > ----------------------------------------------------------- > > (Updated April 19, 2017, 6:48 a.m.) > > > Review request for hive, Thejas Nair and Vaibhav Gumashta. > > > Bugs: HIVE-16355 > https://issues.apache.org/jira/browse/HIVE-16355 > > > Repository: hive-git > > > Description > ------- > > this is a small step toward separating some of the client code from the > service module > > * embedded mode is only supported if the hive-service module is loaded > * use interface instead of implementation > > > Diffs > ----- > > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java > fb18adb69232de9e595611cb95c025378d04f9fb > service/src/java/org/apache/hive/service/auth/HiveAuthFactory.java > dcb6338d3977665b3c3e954acc5cd8dce4ac5048 > service/src/java/org/apache/hive/service/auth/KerberosSaslHelper.java > ea2c689a4fb2e2ba6867b276044cbca0ac6899d3 > service/src/java/org/apache/hive/service/auth/PlainSaslHelper.java > a161e1541e99fe30d7265a97bf196680d0fe905a > > > Diff: https://reviews.apache.org/r/58403/diff/2/ > > > Testing > ------- > > > Thanks, > > Zoltan Haindrich > >
