[
https://issues.apache.org/jira/browse/HIVE-2619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Phabricator updated HIVE-2619:
------------------------------
Attachment: HIVE-2619.D555.1.patch
kevinwilfong requested code review of "HIVE-2619 [jira] Add hook to run in
meatastore's endFunction which can collect more fb303 counters".
Reviewers: njain, heyongqiang, JIRA
I added a new type of listener called MetaStoreEndFunctionListener, which is
called by endFunction in HMSHandler and takes the method's name, and whether it
succeeded. I also overrode FacebookBase's getCounters method to include
counters from these listeners.
These new listeners are configurable in the same way as EventListeners.
I had to modify endFunction and all calls to it to pass in whether or not the
method succeeded.
TEST PLAN
I created an implementation of MetaStoreEndFunctionListener and verified it
ran without exceptions, and it could add fb303 counters.
I also ran the unit tests.
REVISION DETAIL
https://reviews.facebook.net/D555
AFFECTED FILES
conf/hive-default.xml
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreEndFunctionListener.java
metastore/src/java/org/apache/hadoop/hive/metastore/HiveMetaStore.java
metastore/src/java/org/apache/hadoop/hive/metastore/MetaStoreUtils.java
common/src/java/org/apache/hadoop/hive/conf/HiveConf.java
> Add hook to run in meatastore's endFunction which can collect more fb303
> counters
> ---------------------------------------------------------------------------------
>
> Key: HIVE-2619
> URL: https://issues.apache.org/jira/browse/HIVE-2619
> Project: Hive
> Issue Type: Improvement
> Reporter: Kevin Wilfong
> Assignee: Kevin Wilfong
> Attachments: HIVE-2619.1.patch.txt, HIVE-2619.D555.1.patch,
> HIVE-2619.D561.1.patch
>
>
> Create the potential for hooks to run in the endFunction method of HMSHandler
> which take the name of a function and whether or not it succeeded. Also,
> override getCounters from fb303 to allow these hooks to add counters which
> they collect, should this be desired. These hooks can be similar to
> EventListeners, but they should be more generic.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
