----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/61851/#review183655 -----------------------------------------------------------
Thanks for the patch Zsombor! Just one minor comment. metastore/src/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java Lines 38 (patched) <https://reviews.apache.org/r/61851/#comment259727> Shouldn't we set the hikari configurations to HIVE_CONF_RESTRICTED_LIST as well? See: "bonecp." - Peter Vary On Aug. 23, 2017, 4:45 p.m., Barna Zsombor Klara wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/61851/ > ----------------------------------------------------------- > > (Updated Aug. 23, 2017, 4:45 p.m.) > > > Review request for hive and Peter Vary. > > > Bugs: HIVE-17318 > https://issues.apache.org/jira/browse/HIVE-17318 > > > Repository: hive-git > > > Description > ------- > > HIVE-17318: Make Hikari configurable using hive properties in hive-site.xml > > > Diffs > ----- > > > metastore/src/java/org/apache/hadoop/hive/metastore/datasource/DataSourceProviderFactory.java > fa6bb1cc5252a71ccc6f011d5dd062a952de5b8a > > metastore/src/java/org/apache/hadoop/hive/metastore/datasource/HikariCPDataSourceProvider.java > PRE-CREATION > metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnHandler.java > a6d56137b3c4501b74b1e9a3c5d4085b55919710 > > metastore/src/test/org/apache/hadoop/hive/metastore/datasource/TestDataSourceProviderFactory.java > 628460482dc646f8a38f607e815eddaa3cc2a831 > > > Diff: https://reviews.apache.org/r/61851/diff/2/ > > > Testing > ------- > > > Thanks, > > Barna Zsombor Klara > >
