> On Sept. 7, 2017, 4:04 p.m., Gunther Hagleitner wrote: > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java > > Line 148 (original), 173 (patched) > > <https://reviews.apache.org/r/62108/diff/2/?file=1816633#file1816633line174> > > > > you switched from resetting old session's tez q name to new session's > > conf. was that intentional? i don't see why.
conf is passed to open so it's immediately set in the new session in the old code too. - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62108/#review184825 ----------------------------------------------------------- On Sept. 7, 2017, 8:26 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/62108/ > ----------------------------------------------------------- > > (Updated Sept. 7, 2017, 8:26 p.m.) > > > Review request for hive and Gunther Hagleitner. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java cf3f50ba64 > > llap-client/src/java/org/apache/hadoop/hive/llap/registry/impl/LlapZookeeperRegistryImpl.java > 65f8f945aa > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/TezAmInstance.java > PRE-CREATION > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/TezAmRegistryImpl.java > PRE-CREATION > > llap-client/src/java/org/apache/hadoop/hive/registry/impl/ZkRegistryBase.java > c7737706c6 > llap-tez/pom.xml 1e5b2354c1 > > llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java > cf8bd469dc > > llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/endpoint/LlapPluginServerImpl.java > f3c0d5213f > > llap-tez/src/test/org/apache/hadoop/hive/llap/tezplugins/TestLlapTaskSchedulerService.java > 156e62023d > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/SessionExpirationTracker.java > 8bee77ea72 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPool.java > 4f58565a4c > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolManager.java > 1f4705c083 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionPoolSession.java > 005eeedc02 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezSessionState.java > fe5c6a1e45 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/TezTask.java f1f10286a3 > ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java d7592bb966 > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/SampleTezSessionState.java > 973c0cc630 > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezSessionPool.java > d2b98c46ca > ql/src/test/org/apache/hadoop/hive/ql/exec/tez/TestTezTask.java 176692b6e5 > > > Diff: https://reviews.apache.org/r/62108/diff/3/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
