----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/62693/ -----------------------------------------------------------
Review request for hive. Repository: hive-git Description ------- Add a unit test which exercises CompactionTxnHandler.markFailed() and change it to use PreparedStament. Add test for checkFailedCompactions() and change it to use PreparedStatement Add a unit test which exercises purgeCompactionHistory(). Add buildQueryWithINClauseStrings() which is suitable for building in clauses for PreparedStatement Add test code to TestTxnUtils to tickle code in TxnUtils.buildQueryWithINClauseStrings() so that it produces multiple queries. Change markCleaned() to use PreparedStatement Diffs ----- beeline/src/java/org/apache/hive/beeline/HiveSchemaTool.java 84963af10ec13979a7b3976be434efbc21cf2382 metastore/src/java/org/apache/hadoop/hive/metastore/txn/CompactionTxnHandler.java 60839faa352cbf959041a455e9e780dfca0afdc3 metastore/src/java/org/apache/hadoop/hive/metastore/txn/TxnUtils.java 30b155f3b3311fed6cd79e46a5b2abcee9927d91 metastore/src/test/org/apache/hadoop/hive/metastore/txn/TestTxnUtils.java 1497c00e5dc77c02e53767b014a23e5fd8cb5b29 ql/src/test/org/apache/hadoop/hive/metastore/txn/TestCompactionTxnHandler.java f8ae86bea3fe78374c0e0487d66c661f4f0d78ff Diff: https://reviews.apache.org/r/62693/diff/1/ Testing ------- Thanks, Andrew Sherman
