----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63043/ -----------------------------------------------------------
Review request for hive, Aihua Xu, Andrew Sherman, Alan Gates, Janaki Lahorani, Sergio Pena, Sahil Takiar, and Vihang Karajgaonkar. Bugs: 17730 https://issues.apache.org/jira/browse/17730 Repository: hive-git Description ------- HIVE-17730 Queries can be closed automatically The goal of the patch is to replaces all curret uses of QueryWrapper with try-with-resource construct that guarantees that the query is closed. This change affects the scope of the open query, so in all cases where the code was returning the list of query results, I had to copy the list to a new ArrayList to allow access after query close. Diffs ----- metastore/src/java/org/apache/hadoop/hive/metastore/tools/HiveMetaTool.java 22e246f1c914532ed6c67151c261fa709a283ef2 standalone-metastore/src/main/java/org/apache/hadoop/hive/metastore/ObjectStore.java ffb2abdf6294dbd470525ad888bd95feac7e7f06 Diff: https://reviews.apache.org/r/63043/diff/1/ Testing ------- Thanks, Alexander Kolbasov