----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63442/#review190080 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java Line 1656 (original), 1656 (patched) <https://reviews.apache.org/r/63442/#comment267335> why are we setting state to partial here? For operators other than TableScan we derive stats and we keep state as is. ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java Lines 178 (patched) <https://reviews.apache.org/r/63442/#comment267336> Can just remove it. - Ashutosh Chauhan On Oct. 31, 2017, 2:29 p.m., Zoltan Haindrich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63442/ > ----------------------------------------------------------- > > (Updated Oct. 31, 2017, 2:29 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Bugs: HIVE-17934 > https://issues.apache.org/jira/browse/HIVE-17934 > > > Repository: hive-git > > > Description > ------- > > * remove the reactive stat state guessing method > * make the guessing only work when a new object is created > * change the way stat objects are merged > > this patch will most probably break almost all qtest outputs.... > > > Diffs > ----- > > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/spark/SparkMapJoinOptimizer.java > 7a3fae65e8c1c0090b353cdd674f9b67164695e0 > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/stats/annotation/StatsRulesProcFactory.java > a4f60accce852d13a08e21261ac3a8d8ad7121e2 > ql/src/java/org/apache/hadoop/hive/ql/plan/Statistics.java > 8ffb4ce44b71e949577bc0bb7d17aa3ee9bed92f > ql/src/java/org/apache/hadoop/hive/ql/stats/StatsUtils.java > 9ffd12ad3c248176024b573f2d3eb23cab06ee05 > ql/src/test/queries/clientpositive/stats_empty_partition2.q PRE-CREATION > ql/src/test/results/clientpositive/stats_empty_partition2.q.out > PRE-CREATION > > > Diff: https://reviews.apache.org/r/63442/diff/1/ > > > Testing > ------- > > > Thanks, > > Zoltan Haindrich > >
