This is now done. Patch is committed and we deployed the new war file to the ptest server.
Jobs that were waiting in queue at the time of ptest server restart have been retriggered in Jenkins. I hope this change will contribute to the overall code quality of Hive in our future patches to come :) On 21 November 2017 at 17:39, Adam Szita <sz...@cloudera.com> wrote: > Hi, > > In the last days all prerequisites have been resolved for this: > -ASF headers are fixed > -checkstyle is upgraded to support Java8 > -proper checkstyle configuration has been introduced to poms that are > disconnected from Hive's root pom > > Thanks Alan for reviewing these. > > Therefore we plan to move ahead with this tomorrow around 10:00AM CET, do > the commit with Peter Vary and replace the war file among ptest servers > Tomcat webapps. > > Thanks, > Adam > > On 7 November 2017 at 18:42, Alan Gates <alanfga...@gmail.com> wrote: > >> I’ve put some feedback in HIVE-17995. 17996 and 17997 look good. I’ll >> commit them once the tests run. >> >> I think you’ll need to do similar patches for storage-api, as it is also >> not connected to the hive pom anymore. >> >> Alan. >> >> On Tue, Nov 7, 2017 at 6:17 AM, Adam Szita <sz...@cloudera.com> wrote: >> >> > Thanks for all the replies. >> > >> > Vihang: Good idea on making everything green before turning this on. For >> > this purpose I've filed a couple of jiras: >> > -HIVE-17995 <https://issues.apache.org/jira/browse/HIVE-17995> Run >> > checkstyle on standalone-metastore module with proper configuration >> > -HIVE-17996 <https://issues.apache.org/jira/browse/HIVE-17996> Fix ASF >> > headers >> > -HIVE-17997 <https://issues.apache.org/jira/browse/HIVE-17997> Add rat >> > plugin and configuration to standalone metastore pom >> > >> > Sahil: there is an umbrella jira (HIVE-13503 >> > <https://issues.apache.org/jira/browse/HIVE-13503>) for test >> improvements, >> > the Yetus integration itself is also a subtask of it. I think any >> further >> > improvements on what Yetus features we want to enable should go here >> too. >> > >> > Adam >> > >> > >> > >> > >> > >> > >
