It currently complains about no space between ; and // as in “…);//foo”
And also about indentation when a single method call is split into multiple lines. It insists on 4 chars in this case, though we use 2 in (all?) other cases. Could this be dialed down as well? On 12/5/17, 7:26 AM, "Peter Vary" <pv...@cloudera.com> wrote: +1 for the changes > On Dec 5, 2017, at 1:02 PM, Zoltan Haindrich <k...@rxd.hu> wrote: > > Hello, > > I've filed a ticket to make the checkstyle warnings less noisy (https://issues.apache.org/jira/browse/HIVE-18222) > > * set maxlinelength to 140 > I think everyone is working with big-enough displays to handle this :) > There are many methods which have complicated names / arguments / etc ; breaking the lines more frequently hurts readability... > * disabled some restrictions like: declaration&hiding via get/set methods for protected/package fields are not mandatory > > If you don't feel comfortable with these changes, please share your point of view. > > cheers, > Zoltan > >