----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64942/#review194748 -----------------------------------------------------------
llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapTaskSchedulerMetrics.java Lines 187 (patched) <https://reviews.apache.org/r/64942/#comment273719> nit: put this under if? complicated to read. llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapTaskSchedulerMetrics.java Lines 192 (patched) <https://reviews.apache.org/r/64942/#comment273720> same for all these - Prasanth_J On Jan. 4, 2018, 1:50 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64942/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2018, 1:50 a.m.) > > > Review request for hive and Prasanth_J. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > > llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/LlapTaskSchedulerService.java > e97a267843 > > llap-tez/src/java/org/apache/hadoop/hive/llap/tezplugins/metrics/LlapTaskSchedulerMetrics.java > 478f9492a7 > > > Diff: https://reviews.apache.org/r/64942/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >