> On Jan. 5, 2018, 4:32 a.m., Jesús Camacho Rodríguez wrote:
> > ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGrouping.java
> > Line 50 (original), 50 (patched)
> > <https://reviews.apache.org/r/64900/diff/2/?file=1932081#file1932081line50>
> >
> > Return value for Grouping function should be Long now, as otherwise we
> > will not be able to represent some of the possible values.
>
> Prasanth_J wrote:
> Hmm.. I thought grouping() function only return 2 values. 1 for
> aggregated and 0 for non-aggregated. Atleast that's what the javadoc says.
> Should have been boolean :) Correct me if I am wrong.
I think you are right, I missed this comment in the code
// grouping(c1, c2, c3)
// is equivalent to
// 4 * grouping(c1) + 2 * grouping(c2) + grouping(c3)
I will fix it in the next patch.
- Prasanth_J
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/64900/#review194829
-----------------------------------------------------------
On Jan. 5, 2018, 3:32 a.m., Prasanth_J wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/64900/
> -----------------------------------------------------------
>
> (Updated Jan. 5, 2018, 3:32 a.m.)
>
>
> Review request for hive and Jesús Camacho Rodríguez.
>
>
> Bugs: HIVE-18359
> https://issues.apache.org/jira/browse/HIVE-18359
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-18359: Extend grouping set limits from int to long
>
>
> Diffs
> -----
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/GroupByOperator.java 8b94d1d
>
> ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorGroupByOperator.java
> 90145e5
> ql/src/java/org/apache/hadoop/hive/ql/metadata/VirtualColumn.java 0032305
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/reloperators/HiveGroupingID.java
> adcda26
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/rules/HiveExpandDistinctAggregatesRule.java
> 89c5c23
>
> ql/src/java/org/apache/hadoop/hive/ql/optimizer/calcite/translator/HiveGBOpConvUtil.java
> 6f4188c
> ql/src/java/org/apache/hadoop/hive/ql/parse/CalcitePlanner.java 28b4cfe
> ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java 5a88a96
> ql/src/java/org/apache/hadoop/hive/ql/plan/GroupByDesc.java 9d4ad22
> ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFGrouping.java
> cee0e14
> ql/src/test/queries/clientpositive/cte_1.q 15d3f06
> ql/src/test/queries/clientpositive/groupingset_high_columns.q PRE-CREATION
> ql/src/test/results/clientpositive/annotate_stats_groupby.q.out ed3d594
> ql/src/test/results/clientpositive/annotate_stats_groupby2.q.out ffcb20f
> ql/src/test/results/clientpositive/auto_join25.q.out 063d3ca
> ql/src/test/results/clientpositive/cte_1.q.out 9374a32
> ql/src/test/results/clientpositive/groupby_cube1.q.out e5ece81
> ql/src/test/results/clientpositive/groupby_cube_multi_gby.q.out 9a6457c
> ql/src/test/results/clientpositive/groupby_grouping_id3.q.out f13b6e5
> ql/src/test/results/clientpositive/groupby_grouping_sets1.q.out d70f065
> ql/src/test/results/clientpositive/groupby_grouping_sets2.q.out 453b9f7
> ql/src/test/results/clientpositive/groupby_grouping_sets3.q.out be8d20e
> ql/src/test/results/clientpositive/groupby_grouping_sets4.q.out 0c6ead9
> ql/src/test/results/clientpositive/groupby_grouping_sets5.q.out 0bb12e1
> ql/src/test/results/clientpositive/groupby_grouping_sets6.q.out 5b990a1
> ql/src/test/results/clientpositive/groupby_grouping_sets_grouping.q.out
> 1f2f86b
> ql/src/test/results/clientpositive/groupby_grouping_sets_limit.q.out
> b25b0e5
> ql/src/test/results/clientpositive/groupby_grouping_window.q.out 32135e4
> ql/src/test/results/clientpositive/groupby_rollup1.q.out bc1d8a9
> ql/src/test/results/clientpositive/groupby_rollup_empty.q.out 5db3184
> ql/src/test/results/clientpositive/groupingset_high_columns.q.out
> PRE-CREATION
>
> ql/src/test/results/clientpositive/infer_bucket_sort_grouping_operators.q.out
> 5f1d264
> ql/src/test/results/clientpositive/limit_pushdown2.q.out cdd221b
> ql/src/test/results/clientpositive/llap/cte_1.q.out ddef9db
> ql/src/test/results/clientpositive/llap/groupby_rollup_empty.q.out 061b0d7
>
> ql/src/test/results/clientpositive/llap/insert_values_orig_table_use_metadata.q.out
> d135f08
> ql/src/test/results/clientpositive/llap/llap_acid.q.out 38889b9
> ql/src/test/results/clientpositive/llap/llap_acid_fast.q.out 4a7297d
> ql/src/test/results/clientpositive/llap/multi_count_distinct_null.q.out
> 39feaec
> ql/src/test/results/clientpositive/llap/sysdb.q.out 3bd407b
> ql/src/test/results/clientpositive/llap/vector_groupby_cube1.q.out 39de888
> ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id1.q.out
> 7224d59
> ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id2.q.out
> e6075c7
> ql/src/test/results/clientpositive/llap/vector_groupby_grouping_id3.q.out
> da4b81f
> ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets1.q.out
> d2b738b
> ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets2.q.out
> 1877bba
> ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets3.q.out
> 7c9f668
> ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets4.q.out
> 6a5e679
> ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets5.q.out
> 4d8fa16
> ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets6.q.out
> 5e9e204
>
> ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_grouping.q.out
> b81a0d3
>
> ql/src/test/results/clientpositive/llap/vector_groupby_grouping_sets_limit.q.out
> e8ca06e
>
> ql/src/test/results/clientpositive/llap/vector_groupby_grouping_window.q.out
> 4de6ebb
> ql/src/test/results/clientpositive/llap/vector_groupby_rollup1.q.out
> d1263cd
> ql/src/test/results/clientpositive/perf/spark/query18.q.out 88d289c
> ql/src/test/results/clientpositive/perf/spark/query22.q.out 15fe441
> ql/src/test/results/clientpositive/perf/spark/query27.q.out 627821f
> ql/src/test/results/clientpositive/perf/spark/query36.q.out d313337
> ql/src/test/results/clientpositive/perf/spark/query5.q.out 14e0bdb
> ql/src/test/results/clientpositive/perf/spark/query67.q.out 25d37bd
> ql/src/test/results/clientpositive/perf/spark/query70.q.out 862bdb0
> ql/src/test/results/clientpositive/perf/spark/query77.q.out 6dcaf7c
> ql/src/test/results/clientpositive/perf/spark/query80.q.out 606d23c
> ql/src/test/results/clientpositive/perf/spark/query86.q.out 8e159fd
> ql/src/test/results/clientpositive/spark/groupby_cube1.q.out fa1480e
> ql/src/test/results/clientpositive/spark/groupby_rollup1.q.out 460e7db
> ql/src/test/results/clientpositive/spark/limit_pushdown2.q.out f6f0043
> ql/src/test/results/clientpositive/tez/multi_count_distinct.q.out 7f7d354
> ql/src/test/results/clientpositive/vector_grouping_sets.q.out f08c270
> ql/src/test/results/clientpositive/view_cbo.q.out e10cb7a
>
>
> Diff: https://reviews.apache.org/r/64900/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Prasanth_J
>
>
