----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63382/#review195641 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java Lines 226 (patched) <https://reviews.apache.org/r/63382/#comment274904> nit: given that this keeps the files in the set anyway, it can increment the counter once with the size of the set, in the end - Sergey Shelukhin On Jan. 17, 2018, 7:38 p.m., Prasanth_J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63382/ > ----------------------------------------------------------- > > (Updated Jan. 17, 2018, 7:38 p.m.) > > > Review request for hive and Sergey Shelukhin. > > > Bugs: HIVE-17833 > https://issues.apache.org/jira/browse/HIVE-17833 > > > Repository: hive-git > > > Description > ------- > > HIVE-17833: Publish split generation counters > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersNoTezSessionPool.java > e9f6718 > > itests/hive-unit/src/test/java/org/apache/hive/jdbc/TestTriggersTezSessionPoolManager.java > 3b6eb71 > itests/src/test/resources/testconfiguration.properties bd2416f > ql/src/java/org/apache/hadoop/hive/ql/exec/ReduceSinkOperator.java 92741ee > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java d68d646 > ql/src/java/org/apache/hadoop/hive/ql/exec/spark/SparkTask.java 6915cf1 > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveInputCounters.java > PRE-CREATION > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/HiveSplitGenerator.java > 5dd5e80 > > ql/src/java/org/apache/hadoop/hive/ql/exec/tez/monitoring/TezJobMonitor.java > 55e7d7d > ql/src/java/org/apache/hadoop/hive/ql/hooks/PostExecTezSummaryPrinter.java > 45bd6e0 > ql/src/java/org/apache/hadoop/hive/ql/wm/VertexCounterLimit.java 7d6482a > ql/src/test/org/apache/hadoop/hive/ql/wm/TestTrigger.java b686783 > ql/src/test/queries/clientpositive/tez_input_counters.q PRE-CREATION > ql/src/test/results/clientpositive/llap/dp_counter_mm.q.out 662c02a > ql/src/test/results/clientpositive/llap/dp_counter_non_mm.q.out e2ff9a6 > ql/src/test/results/clientpositive/llap/orc_llap_counters.q.out cce0fda > ql/src/test/results/clientpositive/llap/orc_llap_counters1.q.out ef6908f > ql/src/test/results/clientpositive/llap/orc_ppd_basic.q.out 7508dc6 > ql/src/test/results/clientpositive/llap/orc_ppd_schema_evol_3a.q.out > 1157edb > ql/src/test/results/clientpositive/llap/tez_input_counters.q.out > PRE-CREATION > > > Diff: https://reviews.apache.org/r/63382/diff/5/ > > > Testing > ------- > > > Thanks, > > Prasanth_J > >