----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65265/#review195980 -----------------------------------------------------------
Thanks a lot Peter for the patch. It looks really good to me, I have only few nits. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java Lines 323 (patched) <https://reviews.apache.org/r/65265/#comment275450> Maybe this could be moved to a separate test case (like create table with null location). It was a bit hard to notice after the asserts of the previous test case. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java Lines 505 (patched) <https://reviews.apache.org/r/65265/#comment275451> It might be good to check if the table is really deleted. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java Lines 602 (patched) <https://reviews.apache.org/r/65265/#comment275452> This test contains three well defined use cases so I think it would make sense to split them into 3 tests. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java Lines 911 (patched) <https://reviews.apache.org/r/65265/#comment275453> What happens if the location of the table is changed to null? Is it a valid use case or an exception will occur? - Marta Kuczora On Jan. 22, 2018, 3:36 p.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65265/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2018, 3:36 p.m.) > > > Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar. > > > Bugs: HIVE-18509 > https://issues.apache.org/jira/browse/HIVE-18509 > > > Repository: hive-git > > > Description > ------- > > Added the new tests. > Modified AbstractMetaStoreService, so when starting mini-metastore it is > possible to provide configuration value overrides for non-metastore config > values (like fs trash settings) > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesCreateDropAlterTruncate.java > PRE-CREATION > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/minihms/AbstractMetaStoreService.java > ed071f8 > > > Diff: https://reviews.apache.org/r/65265/diff/2/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Peter Vary > >
