> On Jan. 23, 2018, 4:12 p.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java > > Lines 200 (patched) > > <https://reviews.apache.org/r/65285/diff/1/?file=1944365#file1944365line200> > > > > Maybe test for case insensitivity?
Added test case > On Jan. 23, 2018, 4:12 p.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java > > Lines 236 (patched) > > <https://reviews.apache.org/r/65285/diff/1/?file=1944365#file1944365line236> > > > > Maybe test for no db? Added test case > On Jan. 23, 2018, 4:12 p.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java > > Lines 305 (patched) > > <https://reviews.apache.org/r/65285/diff/1/?file=1944365#file1944365line305> > > > > Maybe test for no database? Added test case > On Jan. 23, 2018, 4:12 p.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java > > Lines 347 (patched) > > <https://reviews.apache.org/r/65285/diff/1/?file=1944365#file1944365line347> > > > > Maybe test for case insensitivity? Added test case - Adam ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65285/#review196018 ----------------------------------------------------------- On Jan. 24, 2018, 2:02 p.m., Adam Szita wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65285/ > ----------------------------------------------------------- > > (Updated Jan. 24, 2018, 2:02 p.m.) > > > Review request for hive, Marta Kuczora and Peter Vary. > > > Bugs: HIVE-18483 > https://issues.apache.org/jira/browse/HIVE-18483 > > > Repository: hive-git > > > Description > ------- > > Create tests to cover getPartition(s) methods > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestGetPartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65285/diff/2/ > > > Testing > ------- > > > Thanks, > > Adam Szita > >
