----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65264/#review196144 -----------------------------------------------------------
standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java Lines 63 (patched) <https://reviews.apache.org/r/65264/#comment275648> A lot of the setup and teardown code for all these classes looks pretty similar. Is it worth creating an abstract class (something like `AbstractMetaStoreClientTest`) to encapsulate all the common setup / teardown logic? We don't have to do this for all the JIRAs in HIVE-18371, since most of them are already done. But would be good for future tests. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java Lines 218-221 (patched) <https://reviews.apache.org/r/65264/#comment275651> It's a bit weird that the embedded metastore and remote metastore throw different exceptions (speaking broadly here since this applies to a lot of the tests). Is there any way to fix that? standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java Lines 272 (patched) <https://reviews.apache.org/r/65264/#comment275652> since only one exception is thrown, can use `expected` annotation. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java Lines 338 (patched) <https://reviews.apache.org/r/65264/#comment275653> should we just create a separate class for the list table APIs? they use a different set of tables anyway, and it might be good to split up the different filter tests - Sahil Takiar On Jan. 23, 2018, 11:18 a.m., Peter Vary wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65264/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2018, 11:18 a.m.) > > > Review request for hive, Marta Kuczora, Adam Szita, and Vihang Karajgaonkar. > > > Bugs: HIVE-18481 > https://issues.apache.org/jira/browse/HIVE-18481 > > > Repository: hive-git > > > Description > ------- > > Create IMetaStoreClient tests to cover the table query methods > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestTablesGetListExists.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65264/diff/3/ > > > Testing > ------- > > Run the created tests > > > Thanks, > > Peter Vary > >
