----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/#review196192 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 3309 (patched) <https://reviews.apache.org/r/65276/#comment275739> Maybe add a comment here about the automatic file re-naming convention for acid tables - that the files are listed in order by name, and mapped to bucket 0, 1, etc based on the position of the file name in the list. ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Line 3456 (original), 3471 (patched) <https://reviews.apache.org/r/65276/#comment275743> In the acid case, it looks like the file extension is stripped off? Actually I'm not sure if gz/other compressed types will work correctly if the filename is not provided .. can you test that? ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Line 3471 (original), 3486 (patched) <https://reviews.apache.org/r/65276/#comment275744> Actually the extension is added here, so that is an inconsistency between these two lines for acid tables. - Jason Dere On Jan. 23, 2018, 12:54 a.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65276/ > ----------------------------------------------------------- > > (Updated Jan. 23, 2018, 12:54 a.m.) > > > Review request for hive, Eugene Koifman and Jason Dere. > > > Bugs: HIVE-18516 > https://issues.apache.org/jira/browse/HIVE-18516 > > > Repository: hive-git > > > Description > ------- > > load data should rename files consistent with insert statements for ACID > Tables. > Includes test change for a missed test. > > > Diffs > ----- > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 23983d85b3 > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java > 5868d4dd56 > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveCopyFiles.java > c6a4a8926b > ql/src/test/queries/clientpositive/load_data_acid_rename.q PRE-CREATION > ql/src/test/queries/clientpositive/smb_mapjoin_7.q 4a6afb0496 > ql/src/test/results/clientpositive/beeline/smb_mapjoin_7.q.out 7a6f8c53a5 > ql/src/test/results/clientpositive/llap/load_data_acid_rename.q.out > PRE-CREATION > ql/src/test/results/clientpositive/smb_mapjoin_7.q.out b71c5b87c1 > ql/src/test/results/clientpositive/spark/smb_mapjoin_7.q.out ac49c02913 > > > Diff: https://reviews.apache.org/r/65276/diff/1/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
