----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65349/#review196418 -----------------------------------------------------------
Thanks for the patch Marta, it looks very thourough! I've added my 2 cents: small observations regarding helper methods only. standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java Lines 489-495 (patched) <https://reviews.apache.org/r/65349/#comment276036> When defining table types we should rely on the enum values IMHO: TableType.EXTERNAL_TABLE.name() standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java Lines 536-539 (patched) <https://reviews.apache.org/r/65349/#comment276035> Another way of doing this is: Arrays.stream(input.split("/")).map(v->v.split("=")[1]).collect(toList()) - Adam Szita On Jan. 26, 2018, 1:03 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65349/ > ----------------------------------------------------------- > > (Updated Jan. 26, 2018, 1:03 p.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18544 > https://issues.apache.org/jira/browse/HIVE-18544 > > > Repository: hive-git > > > Description > ------- > > The following methods of IMetaStoreClient are covered by this test. > - Partition appendPartition(String, String, List<String>) > - Partition appendPartition(String, String, String) > > The test covers not just the happy pathes, but the edge cases as well. > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAppendPartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65349/diff/1/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Marta Kuczora > >
