> On Jan. 29, 2018, 2:34 p.m., Peter Vary wrote: > > Nice throughout test cases. > > Thanks Marta! > > > > Fix it and ship it!
Thanks a lot Peter for the review. > On Jan. 29, 2018, 2:34 p.m., Peter Vary wrote: > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitions.java > > Lines 1312 (patched) > > <https://reviews.apache.org/r/65380/diff/1/?file=1949515#file1949515line1312> > > > > Agree with Adam, please move it to another test class. Moved the tests to a separate class. - Marta ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65380/#review196431 ----------------------------------------------------------- On Jan. 30, 2018, 8:15 a.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65380/ > ----------------------------------------------------------- > > (Updated Jan. 30, 2018, 8:15 a.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18566 > https://issues.apache.org/jira/browse/HIVE-18566 > > > Repository: hive-git > > > Description > ------- > > he following methods of IMetaStoreClient are covered by this test. > - int add_partitions_pspec(PartitionSpecProxy) > > The test covers not just the happy pathes, but the edge cases as well. > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestAddPartitionsFromPartSpec.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65380/diff/2/ > > > Testing > ------- > > Run the tests > > > Thanks, > > Marta Kuczora > >