----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65271/#review196636 -----------------------------------------------------------
jdbc/src/java/org/apache/hive/jdbc/HttpRequestInterceptorBase.java Line 91 (original), 96 (patched) <https://reviews.apache.org/r/65271/#comment276342> A nit - I think using "+=" is more readable for appends - cookieHeaderKeyValues += ";" + entry.getKey() + "=" + entry.getValue(); - Thejas Nair On Jan. 31, 2018, 10:50 p.m., Vaibhav Gumashta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65271/ > ----------------------------------------------------------- > > (Updated Jan. 31, 2018, 10:50 p.m.) > > > Review request for hive and Thejas Nair. > > > Bugs: HIVE-18447 > https://issues.apache.org/jira/browse/HIVE-18447 > > > Repository: hive-git > > > Description > ------- > > https://issues.apache.org/jira/browse/HIVE-18447 > > > Diffs > ----- > > > itests/hive-unit/src/test/java/org/apache/hive/service/cli/thrift/TestThriftHttpCLIServiceFeatures.java > 93b10fb4b4 > jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java cb2f09cbf2 > jdbc/src/java/org/apache/hive/jdbc/HttpBasicAuthInterceptor.java 5d2ddb5c21 > jdbc/src/java/org/apache/hive/jdbc/HttpKerberosRequestInterceptor.java > 37862be804 > jdbc/src/java/org/apache/hive/jdbc/HttpRequestInterceptorBase.java > cf1a11ecb6 > jdbc/src/java/org/apache/hive/jdbc/HttpTokenAuthInterceptor.java 59a91dd14c > jdbc/src/java/org/apache/hive/jdbc/Utils.java f7f3854b86 > > > Diff: https://reviews.apache.org/r/65271/diff/2/ > > > Testing > ------- > > > Thanks, > > Vaibhav Gumashta > >
