> On Feb. 2, 2018, 8 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > > Line 3470 (original), 3484 (patched) > > <https://reviews.apache.org/r/65276/diff/7/?file=1951308#file1951308line3494> > > > > Also, shouldn't it be an error if one of the input files has .gz? This > > would normally mean someone manyally compressed the file which should not > > be the case for ORC. Or is this checked elsewhere? > > > > Silently ignoring this most likely will mask an error until someone > > tries to read these files
This is checked elsewhere much earlier. > On Feb. 2, 2018, 8 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java > > Lines 3485 (patched) > > <https://reviews.apache.org/r/65276/diff/7/?file=1951308#file1951308line3495> > > > > The logic here seems to be changed. > > if taskid == -1, then "name" is computed but ignored which wasn't the > > case previously Yes. That means it is not ACID table so we keep the existing behavior which is to use the fullname. The name is only used when the file already exists which is handled right below. - Deepak ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65276/#review196725 ----------------------------------------------------------- On Feb. 1, 2018, 7:10 p.m., Deepak Jaiswal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65276/ > ----------------------------------------------------------- > > (Updated Feb. 1, 2018, 7:10 p.m.) > > > Review request for hive, Eugene Koifman and Jason Dere. > > > Bugs: HIVE-18516 > https://issues.apache.org/jira/browse/HIVE-18516 > > > Repository: hive-git > > > Description > ------- > > load data should rename files consistent with insert statements for ACID > Tables. > Includes test change for a missed test. > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties d86ff58840 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java 3b97dac8ca > ql/src/java/org/apache/hadoop/hive/ql/parse/LoadSemanticAnalyzer.java > 5868d4dd56 > ql/src/test/org/apache/hadoop/hive/ql/TestTxnLoadData.java a9cba456ef > ql/src/test/org/apache/hadoop/hive/ql/metadata/TestHiveCopyFiles.java > c6a4a8926b > ql/src/test/queries/clientnegative/load_data_into_acid.q 2ac5b561ae > ql/src/test/queries/clientpositive/load_data_acid_rename.q PRE-CREATION > ql/src/test/queries/clientpositive/smb_mapjoin_7.q 4a6afb0496 > ql/src/test/results/clientnegative/load_data_into_acid.q.out 46b5cdd2c8 > ql/src/test/results/clientpositive/beeline/smb_mapjoin_7.q.out 7a6f8c53a5 > ql/src/test/results/clientpositive/llap/load_data_acid_rename.q.out > PRE-CREATION > ql/src/test/results/clientpositive/smb_mapjoin_7.q.out b71c5b87c1 > ql/src/test/results/clientpositive/spark/smb_mapjoin_7.q.out ac49c02913 > > > Diff: https://reviews.apache.org/r/65276/diff/7/ > > > Testing > ------- > > > Thanks, > > Deepak Jaiswal > >
