-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65431/
-----------------------------------------------------------

(Updated Feb. 6, 2018, 12:30 a.m.)


Review request for hive, Ashutosh Chauhan and Jesús Camacho Rodríguez.


Changes
-------

Added micromanaged table test and addressed comments


Bugs: HIVE-16605
    https://issues.apache.org/jira/browse/HIVE-16605


Repository: hive-git


Description
-------

This patch introduces support for enable NOT NULL constraint enforcement for 
following type of statements:

* INSERT INTO
* INSERT as SELECT
* INSERT OVERWRITE
* UPDATE
* MERGE


Diffs (updated)
-----

  common/src/java/org/apache/hadoop/hive/conf/HiveConf.java 99e8457c7b 
  itests/src/test/resources/testconfiguration.properties fed9394544 
  ql/src/java/org/apache/hadoop/hive/ql/exec/FunctionRegistry.java 76e85636d1 
  ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java b1e05dffe9 
  ql/src/java/org/apache/hadoop/hive/ql/parse/BaseSemanticAnalyzer.java 
372cfad866 
  ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java b67a03f213 
  ql/src/java/org/apache/hadoop/hive/ql/parse/TypeCheckProcFactory.java 
9fcde76d21 
  ql/src/java/org/apache/hadoop/hive/ql/ppd/OpProcFactory.java e3a9e62bdb 
  
ql/src/java/org/apache/hadoop/hive/ql/udf/generic/GenericUDFEnforceNotNullConstraint.java
 PRE-CREATION 
  ql/src/test/queries/clientnegative/alter_notnull_constraint_violation.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/create_with_constraints_enable.q 
59ebb1e9b2 
  ql/src/test/queries/clientnegative/create_with_constraints_enforced.q  
  ql/src/test/queries/clientnegative/create_with_fk_constraints_enforced.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/create_with_unique_constraints_enforced.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/insert_into_acid_notnull.q PRE-CREATION 
  ql/src/test/queries/clientnegative/insert_into_notnull_constraint.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/insert_multi_into_notnull.q PRE-CREATION 
  ql/src/test/queries/clientnegative/insert_overwrite_notnull_constraint.q 
PRE-CREATION 
  ql/src/test/queries/clientnegative/merge_constraint_notnull.q PRE-CREATION 
  ql/src/test/queries/clientnegative/update_notnull_constraint.q PRE-CREATION 
  ql/src/test/queries/clientpositive/enforce_constraint_notnull.q PRE-CREATION 
  ql/src/test/results/clientnegative/alter_notnull_constraint_violation.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/create_with_constraints_enable.q.out  
  ql/src/test/results/clientnegative/create_with_constraints_enforced.q.out  
  ql/src/test/results/clientnegative/create_with_fk_constraints_enforced.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/insert_into_acid_notnull.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/insert_into_notnull_constraint.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/insert_multi_into_notnull.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/insert_overwrite_notnull_constraint.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/merge_constraint_notnull.q.out 
PRE-CREATION 
  ql/src/test/results/clientnegative/update_notnull_constraint.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/llap/enforce_constraint_notnull.q.out 
PRE-CREATION 
  ql/src/test/results/clientpositive/show_functions.q.out 43e4a5de39 


Diff: https://reviews.apache.org/r/65431/diff/4/

Changes: https://reviews.apache.org/r/65431/diff/3-4/


Testing
-------


Thanks,

Vineet Garg

Reply via email to