> On Feb. 5, 2018, 6:52 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java > > Line 862 (original), 863 (patched) > > <https://reviews.apache.org/r/65413/diff/2/?file=1950137#file1950137line863> > > > > is 'job' cloned somewhere between invocations? If not this seems like > > a bug
This is existing code. Another strange thing here is that there's job (the field) and jobConf (the parameter), and some code in this methods updates one while some updates the other. They are not obviously identical. Does it make sense to investigate/fix in a follow-up jira? > On Feb. 5, 2018, 6:52 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java > > Line 202 (original), 202 (patched) > > <https://reviews.apache.org/r/65413/diff/2/?file=1950138#file1950138line202> > > > > on the client we have isTransactionalTable() to mean MM or full acid > > and isAcidTable() to mean full acid. > > > > Shouldn't this be isAcidRead() to be consistent? I;m going to change these too.. I see that some code calls is(Full)Acid... && !isInsertOnly. These methods should be explicit. > On Feb. 5, 2018, 6:52 p.m., Eugene Koifman wrote: > > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > > Line 507 (original), 507 (patched) > > <https://reviews.apache.org/r/65413/diff/2/?file=1950142#file1950142line507> > > > > stupid RB won't let me edit my own comment... > > Previsouly this check was testing for full acid but now just for > > transactional. Why? It's used to skip global limit optimization. As far as I understand this should also be skipped for insert-only tables - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65413/#review196819 ----------------------------------------------------------- On Jan. 29, 2018, 11:12 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65413/ > ----------------------------------------------------------- > > (Updated Jan. 29, 2018, 11:12 p.m.) > > > Review request for hive and Eugene Koifman. > > > Repository: hive-git > > > Description > ------- > > . > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/conf/HiveConf.java > b7d3e99e1a505f576a06c530080fc72dddcd85ba > > hcatalog/core/src/main/java/org/apache/hive/hcatalog/mapreduce/FosterStorageHandler.java > 5ee8aadfa774a85a0bdbcaf78a636ff6593c43e2 > > hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/TestStreaming.java > 5e12614cfe17030f8fcb56ef8c83b53b8b870c97 > > hcatalog/streaming/src/test/org/apache/hive/hcatalog/streaming/mutate/StreamingAssert.java > c98d22be2e6216e95d9c13f3a26540ca03e7405e > > itests/hive-unit/src/test/java/org/apache/hadoop/hive/ql/txn/compactor/TestCompactor.java > 13059023516edbb58a9129ba9aa49de7e40129e6 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java > d252279be973201227da52d8aecf83b3fcc4656b > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > 68bb168bd23b84dd150cdc4da63d73657f1b33bb > ql/src/java/org/apache/hadoop/hive/ql/exec/FetchTask.java > a7dace955d6fb3dabc4c5e77ef68f83617eb48d1 > ql/src/java/org/apache/hadoop/hive/ql/exec/SMBMapJoinOperator.java > 270b576199c57c109195b85d43e216743a607955 > ql/src/java/org/apache/hadoop/hive/ql/exec/mr/MapredLocalTask.java > abd42ec651927503e7c8c2d9a7d3d415cc9c4ac4 > ql/src/java/org/apache/hadoop/hive/ql/io/AcidUtils.java > eb75308e8393cadf8e69e0e30b303474b89df03e > ql/src/java/org/apache/hadoop/hive/ql/io/HiveInputFormat.java > c3b846c4d2fee8691b4952b9f6cf4dd1d8bd632f > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java > ff2cc0455c64ed210d8ff14a9f112cd91b7314be > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcSplit.java > 61565ef0305006a57b7f608e60ddcdf2b6ff474d > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java > da200049bcbc8f2fe1d793acc7b84f8b99ae67cc > ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcInputFormat.java > 7b157e648646c5a199aaebf04484b81ff1c12478 > ql/src/java/org/apache/hadoop/hive/ql/optimizer/GenMapRedUtils.java > 923372d5b6da42446997051d0758e9aab4881e2e > ql/src/java/org/apache/hadoop/hive/ql/optimizer/physical/Vectorizer.java > 190771ea6b1cbf4b669a8919271b25a689af941b > ql/src/java/org/apache/hadoop/hive/ql/plan/TableScanDesc.java > 661446df0b9fbb5cf248d76205e47dbaa113026f > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > 9152b4e08a7a1044fc7f844d47ae8e180162b78b > ql/src/test/org/apache/hadoop/hive/ql/io/TestAcidUtils.java > 26a96a47f1935de8e985d382b40c8aae604a9880 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestInputOutputFormat.java > 92f005d1dc837ea5ba7d8579892b6e7325940120 > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestOrcRawRecordMerger.java > c6a866a1644f087d260f78e280d07867d81cbc0c > > ql/src/test/org/apache/hadoop/hive/ql/io/orc/TestVectorizedOrcAcidRowBatchReader.java > 65508f4ddd66140a273c8c447c0ee93f4f139454 > > > Diff: https://reviews.apache.org/r/65413/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
