----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65507/#review196979 -----------------------------------------------------------
Fix it, then Ship it! Thanks for the patch Marta, this is incredibly thourough! standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java Lines 1480-1501 (patched) <https://reviews.apache.org/r/65507/#comment277012> I'd mark these helper methods as static - Adam Szita On Feb. 5, 2018, 6:01 p.m., Marta Kuczora wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65507/ > ----------------------------------------------------------- > > (Updated Feb. 5, 2018, 6:01 p.m.) > > > Review request for hive, Peter Vary and Adam Szita. > > > Bugs: HIVE-18580 > https://issues.apache.org/jira/browse/HIVE-18580 > > > Repository: hive-git > > > Description > ------- > > The following methods of IMetaStoreClient are covered by this test. > - int Partition exchange_partition(Map<String, String>, String, String, > String, String) > - List<Partition> Partition exchange_partition(Map<String, String>, String, > String, String, String) > > The test covers not just the happy pathes, but the edge cases as well. > > > Diffs > ----- > > > standalone-metastore/src/test/java/org/apache/hadoop/hive/metastore/client/TestExchangePartitions.java > PRE-CREATION > > > Diff: https://reviews.apache.org/r/65507/diff/1/ > > > Testing > ------- > > Ran the tests > > > Thanks, > > Marta Kuczora > >
