----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65663/#review197837 -----------------------------------------------------------
ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java Lines 218 (patched) <https://reviews.apache.org/r/65663/#comment278123> This is a short lived temp dir, there is no need to inherit perms for this. Actual partition dir perms inherit will be handled in move task. ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java Line 1155 (original), 1161 (patched) <https://reviews.apache.org/r/65663/#comment278124> There is no need for this. This method is called only in operator tree to either create temp dirs or files within temp dirs. In either case inheriting from parent is useless. Move Task sets permissions correctly. No need for this change. ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java Line 1167 (original), 1172 (patched) <https://reviews.apache.org/r/65663/#comment278125> There is no need for this. This method is called only in operator tree to either create temp dirs or files within temp dirs. In either case inheriting from parent is useless. Move Task sets permissions correctly. No need for this change. ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java Lines 2927 (patched) <https://reviews.apache.org/r/65663/#comment278126> Please see the comment above in this method. This is not required. - Ashutosh Chauhan On Feb. 20, 2018, 8:33 p.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65663/ > ----------------------------------------------------------- > > (Updated Feb. 20, 2018, 8:33 p.m.) > > > Review request for hive and Ashutosh Chauhan. > > > Repository: hive-git > > > Description > ------- > > . > > > Diffs > ----- > > common/src/java/org/apache/hadoop/hive/common/FileUtils.java 2b7a57bb36 > common/src/java/org/apache/hadoop/hive/io/HdfsUtils.java 16fc96eae9 > ql/src/java/org/apache/hadoop/hive/ql/exec/AbstractFileMergeOperator.java > 6bba057e76 > ql/src/java/org/apache/hadoop/hive/ql/exec/FileSinkOperator.java a9d03d060a > ql/src/java/org/apache/hadoop/hive/ql/exec/JoinOperator.java 0282763587 > ql/src/java/org/apache/hadoop/hive/ql/exec/MoveTask.java 5cf2c2bc48 > ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 614c29bb15 > ql/src/java/org/apache/hadoop/hive/ql/metadata/Hive.java eefa8f756c > ql/src/java/org/apache/hadoop/hive/ql/txn/compactor/CompactorMR.java > 5deec4b0f9 > > > Diff: https://reviews.apache.org/r/65663/diff/2/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >
