> On Feb. 28, 2018, 1:29 p.m., Teddy Choi wrote: > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/ColumnVectorBatch.java > > Lines 64 (patched) > > <https://reviews.apache.org/r/65766/diff/1/?file=1963551#file1963551line64> > > > > Why is Math.min(3, size) called?
See above, I accidentally added debug changes to the patch, I'll remove them - Sergey ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65766/#review198386 ----------------------------------------------------------- On Feb. 23, 2018, 4:34 a.m., Sergey Shelukhin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65766/ > ----------------------------------------------------------- > > (Updated Feb. 23, 2018, 4:34 a.m.) > > > Review request for hive, Prasanth_J and Teddy Choi. > > > Repository: hive-git > > > Description > ------- > > see jira > > > Diffs > ----- > > itests/src/test/resources/testconfiguration.properties 4a52eb5559 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/ColumnVectorBatch.java > 9262bf0ce3 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapInputFormat.java > bb319f0d4a > > llap-server/src/java/org/apache/hadoop/hive/llap/io/api/impl/LlapRecordReader.java > a69c9a023c > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ColumnVectorProducer.java > 2a2be56cab > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/GenericColumnVectorProducer.java > d66e2f2540 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcColumnVectorProducer.java > 3a7b192a1c > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/OrcEncodedDataConsumer.java > 36810d9480 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/decode/ReadPipeline.java > 06708d34a7 > > llap-server/src/java/org/apache/hadoop/hive/llap/io/encoded/OrcEncodedDataReader.java > a6d2a0497c > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorExtractRow.java > 681d9cad7b > ql/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorSelectOperator.java > 59b3ae9698 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcInputFormat.java 5e29070776 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/OrcRecordUpdater.java > b90ce6ed2f > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/VectorizedOrcAcidRowBatchReader.java > d4b29d5c59 > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReader.java > c1e55c7fda > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedReaderImpl.java > 32bdf6e68e > > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/EncodedTreeReaderFactory.java > 1e7708e9ae > ql/src/java/org/apache/hadoop/hive/ql/io/orc/encoded/Reader.java 50d10e33cd > ql/src/test/queries/clientpositive/llap_acid2.q PRE-CREATION > ql/src/test/results/clientpositive/llap/llap_acid2.q.out PRE-CREATION > > storage-api/src/java/org/apache/hadoop/hive/common/io/encoded/EncodedColumnBatch.java > aa2615060a > > storage-api/src/java/org/apache/hadoop/hive/ql/exec/vector/VectorizedRowBatch.java > bebf7691f7 > > > Diff: https://reviews.apache.org/r/65766/diff/1/ > > > Testing > ------- > > > Thanks, > > Sergey Shelukhin > >